Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/virtual proxy #2955

Merged
merged 17 commits into from
May 15, 2024
Merged

Conversation

Adelechka
Copy link
Contributor

Virtual Proxy Pattern (#2940)

Related: #2940
Pull request description

sample java code with javadoc
test code
UML diagram
README.md file

@Adelechka
Copy link
Contributor Author

Quality Gate Failed Quality Gate failed

Failed conditions 1 Security Hotspot

See analysis details on SonarCloud

file with 1 Security Hotspot isn't in my pull request

proxy/pom.xml Outdated
@@ -55,7 +55,7 @@
<configuration>
<archive>
<manifest>
<mainClass>com.iluwatar.proxy.App</mainClass>
<mainClass>com.iluwatar.com.App</mainClass>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is not intended?

Copy link

sonarcloud bot commented May 15, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot

See analysis details on SonarCloud

@iluwatar iluwatar merged commit abbc332 into iluwatar:master May 15, 2024
1 check passed
@iluwatar
Copy link
Owner

Looks good! Thank you for the contribution 🎉

@all-contributors please add @Adelechka for code

Copy link
Contributor

@iluwatar

I couldn't determine any contributions to add, did you specify any contributions?
Please make sure to use valid contribution names.

I've put up a pull request to add @Adelechka! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants