Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added checks with promises #296

Open
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

dev-steverob
Copy link

I have added an alternative to the Event Emit. This is a promise based workflow to allow for promise based request inside the callbacks and then rejecting the stream based on the callbacks return value. I have tried to keep the coding the same style as the current Event Emit. I have added examples to the Readme also.

@illuspas
Copy link
Owner

Please do not change the current code style.
No spaces between function names and parentheses.

@dev-steverob
Copy link
Author

Sorry it was my IDE that auto lints I will try to stop it and re submit

@chrisspiegl
Copy link

Hello @dev-steverob, I think your PR is very interesting, could you reformat this and resubmit?

@dev-steverob
Copy link
Author

Hello @dev-steverob, I think your PR is very interesting, could you reformat this and resubmit?

Once I get some time yes I will, I have extended my fork quite a bit more since by adding HLS secure keys to protect front end watching so I will have to split out the code again.

@mattmatters
Copy link

Hello @dev-steverob, I think your PR is very interesting, could you reformat this and resubmit?

Once I get some time yes I will, I have extended my fork quite a bit more since by adding HLS secure keys to protect front end watching so I will have to split out the code again.

Hey @dev-steverob, this pr has a lot of benefits to us too (asynchronous validation of stream keys). If you are too busy I would be more than happy to clean this pr up for you. :)

@dev-steverob
Copy link
Author

Hello @dev-steverob, I think your PR is very interesting, could you reformat this and resubmit?

Once I get some time yes I will, I have extended my fork quite a bit more since by adding HLS secure keys to protect front end watching so I will have to split out the code again.

Hey @dev-steverob, this pr has a lot of benefits to us too (asynchronous validation of stream keys). If you are too busy I would be more than happy to clean this pr up for you. :)

My folk has moved on a bit since this PR as I needed more functionality, but your welcome to take anything I have done and put it into a PR. You can message me if you need anything from me

@mattmatters
Copy link

Hello @dev-steverob, I think your PR is very interesting, could you reformat this and resubmit?

Once I get some time yes I will, I have extended my fork quite a bit more since by adding HLS secure keys to protect front end watching so I will have to split out the code again.

Hey @dev-steverob, this pr has a lot of benefits to us too (asynchronous validation of stream keys). If you are too busy I would be more than happy to clean this pr up for you. :)

My folk has moved on a bit since this PR as I needed more functionality, but your welcome to take anything I have done and put it into a PR. You can message me if you need anything from me

Awesome, will do!

@lonasozo
Copy link

Hello guys, this would be really interesting, there is no news on that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants