Update directory commands to use preferred names #5455
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrjohnson
force-pushed
the
5453-preferred-name-find-command
branch
3 times, most recently
from
c487c92
to
53b53ae
Compare
Adding the display name and replacing output of the first and last name with the preferred version as well as saving the preferred version for new students synced into a school to match the behavior of the user sync command.
jrjohnson
force-pushed
the
5453-preferred-name-find-command
branch
from
53b53ae
to
e08d308
Compare
There was a problem hiding this comment.
Is this the new convention for phpDoc?
There was a problem hiding this comment.
I remove the doc expressions when the property is typed, don't like to keep them both so we don't have to keep them in sync.
| @@ -51,7 +51,7 @@ public function testFindByCampusId(): void | |||
| $this->config->shouldReceive('get')->once()->with('ldap_directory_campus_id_property')->andReturn('campusId'); | |||
| $this->ldapManager->shouldReceive('search')->with('(campusId=1234)')->andReturn([['id' => 1]]); | |||
|
|
|||
| $result = $this->obj->findByCampusId(1234); | |||
| $result = $this->obj->findByCampusId('1234'); | |||
There was a problem hiding this comment.
What was the reason for changing this from a number to a string?
There was a problem hiding this comment.
I typed the parameter because it's always a string in production. Just had to update the test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the display name and replacing output of the first and last name with the preferred version as well as saving the preferred version for new students synced into a school to match the behavior of the user sync command.
Refs #5453