Sign redirect requests for CAS #5452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were allowing a cookie, which can be user defined, to redirect users after CAS authentication. This could potentially be tampered with or set by a bad actor. By signing these cookies and validating them we remove this possibility and ensure that whatever is supplied in the cookie was created by us.
This wasn't doing anything as the frontend catches the unauthenticated response and sends the user to the login page. When no account exists there isn't any of the application a user can actually visit.
There is no need to do this ourselves and it's weird and hokey anyway.
jrjohnson
added
the
safe to deploy
|
PR deployed to docker for all containers, you can access with the tag |
There was a problem hiding this comment.
Are there any other places where this cookie is used that would need updating like this?
There was a problem hiding this comment.
I couldn't find any, and it's in that constant so it should have been easy to surface. It's internal entirely to this script and just a way to reliably move data through the CAS redirect process without storing anything on the machine.
michaelchadwick
approved these changes
May 14, 2024
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were allowing a cookie, which can be user defined, to redirect users after CAS authentication. This could potentially be tampered with or set by a bad actor.
By signing these cookies and validating them we remove this possibility and ensure that whatever is supplied in the cookie was created by us.