Lint for trailing comma in multi line arrays #5444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes diffs when an item is added to an array much easier to read. There are a few places where the comma had to be added to a multi line array with a single element, but I'm ok with the trade off.
|
I wasn't sure about this initially, but the whole "makes diffs cleaner" reason actually makes a lot of sense. My only remaining qualm was an interpreter/compilation one, because I wasn't sure if PHP, let alone any other language, would flag it as invalid. Apparently, PHP (and many other languages) is OK with this! I just wasn't in the know, but now I'm a total convert. |
michaelchadwick
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes diffs when an item is added to an array much easier to read. There are a few places where the comma had to be added to a multi line array with a single element, but I'm ok with the trade off.
Inspired by @michaelchadwick's PR comment about this: #5442 (comment) and turned out to be super easy to lint for and auto fix.