Make name LDAP properties configurable #5423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At UCSF the first and last name can be configured to use the lived name values instead of the default ldap attributes. This change allows ilios to consume those values, but keeps the default of sn/givenName for standard LDAP configs.
stopfstedt
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At UCSF the first and last name can be configured to use the lived name values instead of the default ldap attributes. This change allows ilios to consume those values, but keeps the default of sn/givenName for standard LDAP configs.
I added a note to the class comments, but spelling it out here as well. The
LdapManageris untestable because the Symphony LDAP class it relies on is marked as final. Because we'd have to mock the query behavior to test this class we can't even create anLdapFactoryservice below this one. Or at least I couldn't figure out how.