adds user contexts to userevents. #5361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stopfstedt
force-pushed
the
5338_user_event_relationships
branch
4 times, most recently
from
e056dc9
to
8b739ff
Compare
stopfstedt
changed the title
jrjohnson
requested changes
Apr 4, 2024
| $from, | ||
| $to, | ||
| $joinsAndUserContext[0], | ||
| $joinsAndUserContext[1], |
There was a problem hiding this comment.
I'm not loving the array by index here. It's completely self contained in this file, and probably easier to understand that I'm feeling, but reading it a few times it's hard to follow which of these is which. I'm mainly ruminating, I'm ok to keep it.
stopfstedt
force-pushed
the
5338_user_event_relationships
branch
from
8b739ff
to
22397d6
Compare
API version bumped ✔️ |
this is gnarly, but i can't think of a less invasive way to weave these data points in that doesn't involve substantial refactoring of the whole process.
stopfstedt
force-pushed
the
5338_user_event_relationships
branch
from
22397d6
to
325044f
Compare
jrjohnson
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5338