Merge branch 'patrik-http-only-cookie' into 'master'

Add HttpOnly flag to Set-Cookie #200 See merge request ikus-soft/rdiffweb!222
ikus060 · Jun 16, 2022 · a193814 · a193814
2 parents 8a6bd45 + 128ab8f
commit a193814
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/rdiffweb/controller/tests/test_page_login.py b/rdiffweb/controller/tests/test_page_login.py
@@ -34,6 +34,14 @@ def test_getpage(self):
         self.assertStatus('303 See Other')
         self.assertHeaderItemValue('Location', self.baseurl + '/login/?redirect=%2F')
 
+    def test_cookie_http_only(self):
+        # Given a request made to rdiffweb
+        # When receiving the response
+        self.getPage('/')
+        # Then the header contains Set-Cookie with HttpOnly
+        cookie = self.assertHeader('Set-Cookie')
+        self.assertIn('HttpOnly', cookie)
+
     def test_getpage_with_plaintext(self):
         """
         Requesting plain text without being authenticated should show the login form.

diff --git a/rdiffweb/rdw_app.py b/rdiffweb/rdw_app.py
@@ -195,6 +195,7 @@ def __init__(self, cfg):
                 'tools.sessions.debug': cfg.debug,
                 'tools.sessions.storage_class': session_storage_class,
                 'tools.sessions.storage_path': self._session_dir,
+                'tools.sessions.httponly': True,
                 'tools.ratelimit.debug': cfg.debug,
                 'tools.ratelimit.delay': 60,
                 'tools.ratelimit.anonymous_limit': cfg.rate_limit,