Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use expect_equal() where relevant #1337

Draft
wants to merge 124 commits into
base: main
Choose a base branch
from
Draft

refactor: use expect_equal() where relevant #1337

wants to merge 124 commits into from

Conversation

maelle
Copy link
Contributor

@maelle maelle commented Apr 8, 2024

Part of #1331

maelle added 30 commits April 8, 2024 14:31
@maelle
refactor: add test refactoring script
661a382
@maelle
refactor: remove deprecated expect_that() from test-add.edges.R
5db7f26
@maelle
refactor: remove deprecated expect_that() from test-add.vertices.R
6f84fe8
@maelle
refactor: remove deprecated expect_that() from test-adjacency.spectra…
0546c21 
…l.embedding.R
@maelle
refactor: remove deprecated expect_that() from test-all.st.cuts.R
8fc9df1
@maelle
refactor: remove deprecated expect_that() from test-alpha.centrality.R
fcd7f22
@maelle
refactor: remove deprecated expect_that() from test-arpack.R
22dbf96
@maelle
refactor: remove deprecated expect_that() from test-articulation.poin…
a335e36 
…ts.R
@maelle
refactor: remove deprecated expect_that() from test-as.directed.R
99cb026
@maelle
refactor: remove deprecated expect_that() from test-as.undirected.R
d652a61
@maelle
refactor: remove deprecated expect_that() from test-assortativity.R
0dde4a8
@maelle
refactor: remove deprecated expect_that() from test-attributes.R
eea4388
@maelle
refactor: remove deprecated expect_that() from test-authority.score.R
65d80f0
@maelle
refactor: remove deprecated expect_that() from test-average.path.leng…
71f43ac 
…th.R
@maelle
refactor: remove deprecated expect_that() from test-ba.game.R
423ffcd
@maelle
refactor: remove deprecated expect_that() from test-betweenness.R
284444f
@maelle
refactor: remove deprecated expect_that() from test-biconnected.compo…
18a47ee 
…nents.R
@maelle
refactor: remove deprecated expect_that() from test-bipartite.project…
45053fe 
…ion.R
@maelle
refactor: remove deprecated expect_that() from test-bipartite.random.…
5b895b2 
…game.R
@maelle
refactor: remove deprecated expect_that() from test-bonpow.R
483d7f1
@maelle
refactor: remove deprecated expect_that() from test-bridges.R
9564fbc
@maelle
refactor: remove deprecated expect_that() from test-bug-1032819.R
ef1f1d3
@maelle
refactor: remove deprecated expect_that() from test-bug-1033045.R
4eac4ec
@maelle
refactor: remove deprecated expect_that() from test-bug-1073705-index…
28faad0 
…ing.R
@maelle
refactor: remove deprecated expect_that() from test-bug-1073800-clique.R
5ad3089
@maelle
refactor: remove deprecated expect_that() from test-canonical.permuta…
8683d05 
…tion.R
@maelle
refactor: remove deprecated expect_that() from test-cliques.R
6a86500
@maelle
refactor: remove deprecated expect_that() from test-closeness.R
e80ef32
@maelle
refactor: remove deprecated expect_that() from test-clusters.R
2745380
@maelle
refactor: remove deprecated expect_that() from test-coloring.R
ef48d40
maelle added 21 commits April 8, 2024 14:47
@maelle
refactor: remove deprecated expect_that() from test-operators4.R
228cd93
@maelle
refactor: remove deprecated expect_that() from test-optimal.community.R
9108899
@maelle
refactor: remove deprecated expect_that() from test-pajek.R
e2138a4
@maelle
refactor: remove deprecated expect_that() from test-paths.R
f8ea7d4
@maelle
refactor: remove deprecated expect_that() from test-plot.R
96dd436
@maelle
refactor: remove deprecated expect_that() from test-reciprocity.R
03c3b51
@maelle
refactor: remove deprecated expect_that() from test-rewire.R
ffd5976
@maelle
refactor: remove deprecated expect_that() from test-sample.R
07cbacf
@maelle
refactor: remove deprecated expect_that() from test-sbm.game.R
44cb718
@maelle
refactor: remove deprecated expect_that() from test-scan.R
74796b6
@maelle
refactor: remove deprecated expect_that() from test-sdf.R
b97146a
@maelle
refactor: remove deprecated expect_that() from test-sgm.R
25ec3ca
@maelle
refactor: remove deprecated expect_that() from test-sphere.R
d30de54
@maelle
refactor: remove deprecated expect_that() from test-topology.R
e23770b
@maelle
refactor: remove deprecated expect_that() from test-transitivity.R
83fe949
@maelle
refactor: remove deprecated expect_that() from test-trees.R
ebc0620
@maelle
refactor: remove deprecated expect_that() from test-triangles.R
a283453
@maelle
refactor: remove deprecated expect_that() from test-unfold.tree.R
7425dda
@maelle
refactor: remove deprecated expect_that() from test-walktrap.community.R
11d1523
@maelle
refactor: remove deprecated expect_that() from test-weighted_cliques.R
cfb51e2
@maelle
add tolerance
060d66e
@aviator-app Aviator app
Copy link
Contributor

aviator-app bot commented Apr 8, 2024

Current Aviator status

Aviator will automatically update this comment as the status of the PR changes.
Comment /aviator refresh to force Aviator to re-examine your PR (or learn about other /aviator commands).

This pull request is currently open (not queued).

How to merge

To merge this PR, comment /aviator merge or add the mergequeue label.

See the real-time status of this PR on the Aviator webapp.
Use the Aviator Chrome Extension to see the status of your PR within GitHub.

@maelle maelle changed the title refactor: add test refactoring script refactor: use expect_equal() where relevant Apr 8, 2024
@maelle
Copy link
Contributor Author

maelle commented Apr 8, 2024

The last commit is of particular interest since it adds a tolerance argument to expect_equal() calls that failed. 😅

@maelle maelle marked this pull request as draft April 9, 2024 12:15
@maelle
Copy link
Contributor Author

maelle commented Apr 9, 2024

Do this after merging/closing most of the open PRs. cc @krlmlr

@krlmlr krlmlr added generated ✨ PRs that can easily be regenerated and should be merged last upkeep maintenance, infrastructure, and similar labels Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
generated ✨ PRs that can easily be regenerated and should be merged last upkeep maintenance, infrastructure, and similar
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maelle @krlmlr