-
-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/Steiner Tree #2288
base: master
Are you sure you want to change the base?
Feat/Steiner Tree #2288
Conversation
Updated the master branch. Astyled again.. accidentally pushed DS_Store which was later deleted as well as returned the gitignore back to original
Thanks, this is great, and will make it much easier to continue! Can you please remove the accidentally committed |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2288 +/- ##
==========================================
+ Coverage 84.37% 84.42% +0.04%
==========================================
Files 376 377 +1
Lines 61633 61886 +253
Branches 12060 12118 +58
==========================================
+ Hits 52004 52248 +244
- Misses 9629 9638 +9
... and 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Just wondering if there is any further action to be taken by us. |
Thank you, not at the moment. I also needed to deal with some other PRs. I will try to get back to this in February, but until then I'm overwhelmed. |
Could you add the function to src/CMakeLists.txt and the test to tests/CMakelists.txt? Then the tests will run. Tests you could add:
review notes: I made a brute forcer, which confirms that the resulting trees in the tests have minimum weights. Comments on the algorithm. These are a bit preliminary, because I don't have a complete overview of how the algorithm works. But I just wanted to write things down things I noticed. generateSubsets:
fetchIndexofMapofSets:
steiner_dreyfus_wagner:
|
Is the Steiner Tree algorithm available now in March 2023? |
The PR is still unmerged; you can try checking out this branch and compiling it on your own if you want to use the code in this PR, but it's not in an official release yet. |
…ction to CMakeLists.txt which was causing the build error
@GroteGnoom - What should be the next steps? |
Any update on this. |
Sorry, I've been away for a long time, and am also quite busy now. Last time I checked everything seemed to work correctly, but I still need double check if we haven't missed anything. |
Sounds good. Take your time. |
I was wondering whether there are more steps that have to be taken from our end for this PR in terms of testing. I was thinking if there's any update about the code review. |
Maybe I have time this weekend or the weekend after to take another look. |
I checked again, added some tests, and I can't seem to find any inputs where your algorithm goes wrong (if I remember correctly some errors could be handled better). I haven't checked the code itself, so I'll have a talk with my colleagues about merging it like this. |
All right 🥳 we will look at the code and the docs to see if it still needs work, but the functionality seems there :) So thank you for all your work, and we'll take it from here to get it merged! |
@GroteGnoom ask me for a review when you are done with this and I'll have a final look before it is merged. |
So you get the same error when there's 2 terminals and they are not connected.
As per instructions from the previous PR Link. We fetch upstream the master branch , created a new branch add added the 4 files that we worked on in the previous PR to update the files.
The functionality that is being developed is calculating the Steiner tree in a graph. Steiner Tree is created on basis of subset of terminals in the graphs with the condition that length of the tree should be minimum.
We are following the approach suggested in this paper - https://arxiv.org/abs/1710.00668
Also, we are taking reference of an FPT algorithm known as Dreyfus- Wagner algorithm - https://onlinelibrary.wiley.com/doi/10.1002/net.3230010302