Add meta parameter to mapData callback
#456
Open
+195
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on query and json mutation factories
igorkamyshev
requested changes
Mar 20, 2024
| @@ -143,7 +146,10 @@ describe('createJsonMutation', () => { | |||
| expect(listeners.onSuccess).toHaveBeenCalled(); | |||
| expect(listeners.onSuccess).toHaveBeenCalledWith( | |||
| expect.objectContaining({ | |||
| result: null, | |||
| result: { | |||
There was a problem hiding this comment.
🚨 It is breaking change, and I do not see any reasons to do it 🤔
We can just use { result, meta: { response: { headers } }, params }, it won't break user's code and will work well for your use cases.
| @@ -52,7 +52,12 @@ describe('fetch/json.response.data', () => { | |||
| params: { body: {} }, | |||
| }); | |||
|
|
|||
| expect(watcher.listeners.onDoneData).toBeCalledWith({ test: 'value' }); | |||
| expect(watcher.listeners.onDoneData).toBeCalledWith({ | |||
There was a problem hiding this comment.
🤓 in my opinion, { result, meta: { response: { headers } } } would be better to mirror the final structure in Queries
| @@ -214,9 +214,43 @@ export function createJsonMutation(config: any): Mutation<any, any, any> { | |||
| response: { status: config.response.status }, | |||
| }); | |||
|
|
|||
| let responseHeaders: Record<string, string> = {}; | |||
There was a problem hiding this comment.
🚨 it's broken:
- In the case of two concurrent runs of Mutation, headers can be mixed up
- It does not support Scope API and will be broken during SSR/tests/Storybook
| @@ -324,6 +324,38 @@ export function createJsonQuery(config: any) { | |||
| }, | |||
| }); | |||
|
|
|||
| let responseHeaders: Record<string, string> = {}; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.