Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Issue OF-1933 Step 1 #1538

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix Issue OF-1933 Step 1 #1538

wants to merge 2 commits into from

Conversation

deleolajide
Copy link
Member

First step is to notify members only room that uses a shared group when group members join or leave.

guusdk
guusdk reviewed Nov 29, 2019
View reviewed changes
Copy link
Member

@guusdk guusdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change will get complex fast, I think. It might be good to strictly limit the commit to non-white-line changes (maybe add the white-line changes to a different commit?). It'd also be good to add javadoc to the methods that you introduced.

xmppserver/src/main/java/org/jivesoftware/openfire/muc/spi/LocalMUCRoom.java Show resolved Hide resolved
@akrherz
Copy link
Member

akrherz commented Oct 20, 2020

@deleolajide What's the status of this PR?

@deleolajide
Copy link
Member Author

@deleolajide What's the status of this PR?

It is on hold for now. It has a much lower priority as the project that requested it no longer needs it. I hope to work on it sometime in the future and do a proper job of it then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guusdk guusdk guusdk left review comments

Assignees
No one assigned
Labels
Needs Rebased
Projects
None yet
Milestone
No milestone
3 participants
@deleolajide @akrherz @guusdk