[WIP, RFC] Extensibility improvements #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
customizable - list of movable celebrations - dates provider (replacement of CalendariumRomanum::Temporale::Dates) - celebration factory instead of dates provider and celebration factory the data/logic in question can also be specified inline, as part of the celebration list
+ responsibility for determining season moved from BaseTemporale to the seasons themselves
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses some of the most painful issues encountered when working on custom
Temporaleimplementations (1, 2), partly covered already in issue #49.Most importantly new class
BaseTemporaleis extracted as superclass ofTemporale. It provides facilities for definingTemporaleimplementations customized in most aspects:An important change (which I'm not yet 100% decided to leave in place) is moving the logic of season determination (see the new implementation of
Temporale#season) fromTemporaleto theSeasoninstances.Issues still waiting to be addressed: to make customizable also
Comments are most welcome.