Generator iza #86
Closed
Generator iza #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 9f5c581.
* Seperated fetchData to gain Single Responsibility * Removed Param type since only two options needed max * Added fetchJson with generic return type * Added fetchText * Used fetchData in fetchJson and fetchText for DRY Refactored fetching sheet data * Created SheetService * Moved all sheet related logic to SheetService
* Add early return in render() if contactTemplateArgs are still undefinded
* Changed var parser to const parser * Used fetchJson utils method instead of plain fetch
* Using the SheetService to get sitemap insted of plain fetch * Instanziateing paser just onces insted of for each post * Shortend loops
* Parsed html before using the html fetch string * Made every step by step readable. * Since the params came from extern source every template arg is optional
# Conflicts: # dist/main/main.js.map # src/components/sidebar/sidebarNav.ts # src/components/sidebar/sidebarPosts.ts # types/components/sidebar/sidebarNav.d.ts
* Changed use of shared types
* Implemented SheetService as a Singleton * Change FetchCache.ts Singleton implementation * Change cache implementation from array to map
* Link aktion text description needed, "More" is not enough
Feature/font
* Release Sidekick Library Setup Merge develop into master * Added jsdoc and types for addClasses.ts * Added jsdoc and types for createOptimizedPicture.ts * Continuous Integration Build Project * Added doc and types for getMetadata.ts * Add an example to getMetadata.ts * Add jsdoc and types to replaceBySpecifier.ts * Add jsdoc and types to toCamelCase.ts * * Removed typ-check since the name is already expected to be type string * Add jsdoc and types to toClassName.ts * Continuous Integration Build Project * * Add jsdoc to undefinedOnEmpty.ts * * Change arrow function to function, to be consistent with the other utils functions. * * Add jsdoc to wrap.ts * Fix typo alternate to alternative * Adjust createOptimizedPicture.ts * Correct the examples to have number string values * Adding Breakpoint as a new Interface * Continuous Integration Build Project * Review adjustments * Add meta tag to the examples * Renamed name property to value * Review adjustments fix example output * Continuous Integration Build Project * Change breakpoint width and height type from string to number * Rebuild * Continuous Integration Build Project --------- Co-authored-by: eKrausedivae <156672452+eKrausedivae@users.noreply.github.com> Co-authored-by: christian.schmidt <christian.schmidt@diva-e.com> Co-authored-by: eds-editorial Continuous Integration <eds-editorial-ci@diva-e.com>
* fix #22 Wrap a try catch around the import to catch the import error so the rest of the imports can still be done and the projekt does not break on one missing file. * Removing test block for on build site test * Continuous Integration Build Project * Review changes: Simplified status logic for loading blocks * Continuous Integration Build Project * Continuous Integration Build Project --------- Co-authored-by: christian.schmidt <christian.schmidt@diva-e.com> Co-authored-by: eds-editorial Continuous Integration <eds-editorial-ci@diva-e.com>
* added block banner style * added fonts styles * added loadBlockStyles to loadBlocks method * added libs styles to all scss file * added features and posts block styles * fix undefinedOnEmpty helper * remove dist for test * Continuous Integration Build Project * remove comment * import scss files from ts modules instead vite.config * remove counter component * added lazy styles * run build * added load block styles to loadBlock method * refactor vite.config.ts * rename generateBlockEntries parameter * resolve #29 (comment) * rename generateBlockEntries parameter * resolve #29 (comment) * check if lazyStyles path is not empty * resolve #29 (comment) * Continuous Integration Build Project * remove banner.scss * remove generated banner css * Revert "remove banner.scss" This reverts commit c759a56. * import banner.scss * generate block entries dynamically * laod fonts scss if defined * commit types --------- Co-authored-by: eds-editorial Continuous Integration <eds-editorial-ci@diva-e.com>
* added FetchService added FetchService to pipeline and cache GET requests * cleanup FetchService * Continuous Integration Build Project --------- Co-authored-by: samuelecalamita <samuelecalamita@gmail.com> Co-authored-by: eds-editorial Continuous Integration <eds-editorial-ci@diva-e.com>
* added extractSidekickLibId function and updated banner block * fixed contenteditable bug * added getWindowLocation func * hid layout elements when sidekick library active * small bugfix * small code improvement in main * fixed path * refactored isSidekickLibraryActive * remove post url if sidekick lib active * fixed posts path * Continuous Integration Build Project * resolve merge conflict in createOptimizedPicture * refactored sidekick functions into own folder and added documentation * Fixed lint error * Continuous Integration Build Project * Merge branch 'develop' into feature/sidekick-library-config * Continuous Integration Build Project * added directive for sidekick lib * moved sidekick library styles to separate file * added custom sidekick directive * remove unused import * fix CLS lighthouse score --------- Co-authored-by: samuelecalamita <samuelecalamita@gmail.com> Co-authored-by: eds-editorial Continuous Integration <eds-editorial-ci@diva-e.com>
* Optimize - loadComponents func - decorateImages * Separate services in main.ts into single files * try to remove settimeout * Add inactive class by default * inactive class handling * WIP * wip * created table and form component * table block created * building a table block * form block rebuild * function renderButtonField implemented in form compo * created table block * form block fixed * form compo fixed * form update * form block importiert * Continuous Integration Build Project * Test * Continuous Integration Build Project * Remove dist * Continuous Integration Build Project * Added post functionality to forms * changed implemented * Refactored form fields * table block rebuilt * removed table component * tabel compo details deleted * added value and required to properties * table adjustment * Added fieldWrapper for legend, labels and fieldsets * added toggle field * build dist * added extractSidekickLibId function and updated banner block * fixed contenteditable bug * improved table block code * improved form * strong selector for other cells * improved code * created form component * fixed path * updated extractSidekickLibId name * table block updated * hide form block until rendered * apply table content styles * deleted dist * Continuous Integration Build Project * moved form styles to block itself * run build * added table styles * import table styles --------- Co-authored-by: Ingo Fahrentholz <ingo.fahrentholz@diva-e.com> Co-authored-by: izabela.horodenska <izabla.horodenska@diva-e.com> Co-authored-by: eds-editorial Continuous Integration <eds-editorial-ci@diva-e.com> Co-authored-by: Elanor Krause <elanor.krause@diva-e.com> Co-authored-by: samuelecalamita <samuelecalamita@gmail.com>
* WIP: Icon overview base * WIP: Get while building the icon names and collected them in an array to render each icon once * WIP: Added Icon overview styling and adjust the template * Created Icon Overview * Read all icons from the icons directory and render them in a grid * Each icon is clickable and copies the icon name into the clipboard * A toast appears with an information text * Continuous Integration Build Project * Create a toast component * Build new dist * Continuous Integration Build Project * Build after merge * Fixed toast only displayed once * Rebuild * Continuous Integration Build Project * WIP: Review changes * Continuous Integration Build Project * WIP: Rebuild * WIP: Review adjustments * Created ICON_PATh constant * Adjust paths to use constant ICON_PATH * Adjust path to use the icons in public/icons since src/icons gets removed * Rebuild * Remove src/icons * Continuous Integration Build Project * Change name from ICON_PATH to ICONS_PATH * Moved src/icons to public/icons * Use renderIcon template function * Add dynamic types for icons * Use renderIcon template function * Rebuild and adjust types where Icons is used * Continuous Integration Build Project * Refactoring icons-overview.ts * Moved generate:iconNames to own script * Adjust toast to fade in and out * Adjust icon overview styling * Rebuild * Redo renaming * Adding more meaningfully default message * Rebuild * Continuous Integration Build Project * Import toast only on creation * Rebuild * Moved constants.ts * Continuous Integration Build Project * Adjustments after Merge * Moved iconNameType generation to vite helpers * Add check for optional input in vite config * Removed generateIconTypes.js * Canged require to import * Imports only functoin that needed in vite helper * Rebuild * Add @types/node for the vite.helpers.ts * Moved styles to bloc styles * rebuild * Continuous Integration Build Project * added typeComment to icons.type file * added icon paths to the config object * generate icon type just for svg files * added icons-overview description * adjust icon overview styles * use renderIcon function * change toast default duration --------- Co-authored-by: christian.schmidt <christian.schmidt@diva-e.com> Co-authored-by: eds-editorial Continuous Integration <eds-editorial-ci@diva-e.com> Co-authored-by: samuelecalamita <samuelecalamita@gmail.com>
* dont render image with no or default src * minor code stlye fix * added default image * run build --------- Co-authored-by: samuelecalamita <samuelecalamita@gmail.com>
Merge master into develop
* Install jest * Add jest to package.json * Add ts-jest to package.json * Create test * Create test:ci * Create test:watch * Create test:coverage * Setup Test env settings: * Added "ts-node" * Added "@happy-dom/jest-environment" * Created jest.config.ts with jest init * Adjust jest.config.ts * Added jest types to tsconfig.json * Removed jest.config.js * Clear up jest.config.ts * Added ts-jest and removed ts-node * Added unit tests for addClasses.ts * Test "adds classes to an HTML element" * Test "calls toClassesName for each test class" * Added unit tests for createOptimizedPicture.ts * Corrected jsdoc mention of name instead of value * Added unit tests for getMetadata.ts * Added unit tests for replaceBySpecifier.ts * Add handling for empty strings * Continuous Integration Build Project * Added unit tests for toCamelCase.ts * Added unit tests for toClassName.ts * Extend toCamelCase * Continuous Integration Build Project * Create test for undefinedOnEmpty.ts * Merged and added ts-node * Continuous Integration Build Project * Add test to ci * Adjusting createOptimizedPicture.spec.ts * correct ci test step * make tests fails on ci * Revert "make tests fails on ci" This reverts commit ae9c071. * Review fix: Fix toClassName.spec.ts * Review fix: Renamed ci step from Run Jest tests to Run unit tests * Added case for converting from PascalCase to camelCase * Review fix: Changed specifier * Review fix: changed config to jestConfig and removed tsx * Review fix: fix test * Removed extractSidekickLibraryId.ts * Added test for wrap.spec.ts * Corrected typo --------- Co-authored-by: christian.schmidt <christian.schmidt@diva-e.com> Co-authored-by: eds-editorial Continuous Integration <eds-editorial-ci@diva-e.com> Co-authored-by: samuelecalamita <samuelecalamita@gmail.com>
* WIP #55 typescript-config * Added alias paths * Adjust import paths with alias paths * Adjust directory names for more consistent naming * Compared changes from poc projekt with editorial * Added directory's like helper,directives, constants, and types * Adjust icon type helper to create icon type in type dir * Added the paths to vite * Run build * WIP #55 typescript-config * Added paths to jest config * Rebuild * WIP #55 typescript-config * Corrected test of js-ts * Added "skipLibCheck": true to tsconfig since the fsWatcher type causes problem during build Type 'FSWatcher' is missing the following properties from type 'FSWatcher': ref, unref * Continuous Integration Build Project --------- Co-authored-by: christian.schmidt <christian.schmidt@diva-e.com> Co-authored-by: eds-editorial Continuous Integration <eds-editorial-ci@diva-e.com>
* Install jest * Add jest to package.json * Add ts-jest to package.json * Create test * Create test:ci * Create test:watch * Create test:coverage * Setup Test env settings: * Added "ts-node" * Added "@happy-dom/jest-environment" * Created jest.config.ts with jest init * Adjust jest.config.ts * Added jest types to tsconfig.json * Removed jest.config.js * Clear up jest.config.ts * Added ts-jest and removed ts-node * Added unit tests for addClasses.ts * Test "adds classes to an HTML element" * Test "calls toClassesName for each test class" * Added unit tests for createOptimizedPicture.ts * Corrected jsdoc mention of name instead of value * Added unit tests for getMetadata.ts * Added unit tests for replaceBySpecifier.ts * Add handling for empty strings * Continuous Integration Build Project * Added unit tests for toCamelCase.ts * Added unit tests for toClassName.ts * Extend toCamelCase * Continuous Integration Build Project * Create test for undefinedOnEmpty.ts * Merged and added ts-node * Continuous Integration Build Project * Add test to ci * Adjusting createOptimizedPicture.spec.ts * correct ci test step * make tests fails on ci * Revert "make tests fails on ci" This reverts commit ae9c071. * Review fix: Fix toClassName.spec.ts * Review fix: Renamed ci step from Run Jest tests to Run unit tests * Added case for converting from PascalCase to camelCase * Review fix: Changed specifier * Review fix: changed config to jestConfig and removed tsx * Review fix: fix test * Create extractSidekickLibraryId.spec.ts * Create getHref.spec.ts * Create getLocation.spec.ts * Create getOrigin.spec.ts * Create isSidekickLibraryActive.spec.ts * Build * Fixed typo and build * Removed extractSidekickLibraryId.ts * Added test for wrap.spec.ts * Corrected typo * Build * Continuous Integration Build Project * Rebuild * build * Build * Continuous Integration Build Project * typo --------- Co-authored-by: christian.schmidt <christian.schmidt@diva-e.com> Co-authored-by: eds-editorial Continuous Integration <eds-editorial-ci@diva-e.com> Co-authored-by: samuelecalamita <samuelecalamita@gmail.com>
* Added husky config with eslint and stylelint checks * fix stylelint issue * update package-lock.json * Continuous Integration Build Project --------- Co-authored-by: samuelecalamita <samuelecalamita@gmail.com> Co-authored-by: eds-editorial Continuous Integration <eds-editorial-ci@diva-e.com>
* #36: add kluntje services to project * #36: add PlaceholderService and error handling to all components that use fetchservice * #36: created dist files * Merge branch 'develop' into feature/error-handling * Extended error handling for fetch service * Logging error of failed response with additional information * Throwing error with additional information * Adding informative debug log for posts.ts * Adding informative debug log for form.ts * Adding informative debug log for sidebarContact.ts * Adding informative debug log for sidebarFooter.ts * Adding informative debug log for sidebarNav.ts * Adding informative debug log for sidebarPosts.ts * Adding informative debug log for header.ts * Add DebuggerService to Form.ts * Switched and extend error log with DebuggerService * Add DebuggerService to Icon.ts * Switched and extend error log with DebuggerService * Add DebuggerService to main.service.ts * Switched and extend error log with DebuggerService * Add DebuggerService to placeholder.service.ts * Switched and extend error log with DebuggerService * Fixed placeholder.service.ts * Uses now fetch service * Logs informative error logs * throws Error by not founded key * Added Placeholder types Shared types SheetResponse expects now a type for data key Adjust Posts.ts * Changed logic to filter unsuccessfully posts fetches * Fixed placeholder logic if no posts available * Continuous Integration Build Project * Fixed sidebarPosts.ts * Moved the fetching of the placeholder to the connected life hook since it needs an async call and they cant be in the render method * Made the placeholder a state to trigger rerender if the promise is resolved * Adjust the render conditions to be easier readable and follow the rule of early return. * build * run build * show just post in the post directory --------- Co-authored-by: Sabrina Müller <sabrina.mueller@diva-e.com> Co-authored-by: christian.schmidt <christian.schmidt@diva-e.com> Co-authored-by: eds-editorial Continuous Integration <eds-editorial-ci@diva-e.com> Co-authored-by: samuelecalamita <samuelecalamita@gmail.com>
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
Commits
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please always provide the GitHub issue(s) your PR is for, as well as test URLs where your change can be observed (before and after):
Fix #
Test URLs: