Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDEMPIERE-6122 Query class to accept a list of columns to select #2345

Merged
merged 6 commits into from
May 7, 2024

Conversation

hengsin
Copy link
Collaborator

@hengsin hengsin commented May 4, 2024

https://idempiere.atlassian.net/browse/IDEMPIERE-6122

Pull Request Checklist

  • My code follows the code guidelines of this project
  • My code follows the best practices of this project
  • I have performed a self-review of my own code
  • My code is easy to understand and review.
  • I have checked my code and corrected any misspellings
  • In hard-to-understand areas, I have commented my code.
  • My changes generate no new warnings

Tests

  • I have tested the direct scenario that my code is solving
  • I checked all collaterals that can be affected by my changes, and tested other potential affected scenarios
  • New and existing unit tests pass locally with my changes
  • I have added unit tests that prove my fix is effective or that my feature works

Documentation

  • I have made corresponding changes to the documentation as follows:
    • New feature (non-breaking change which adds functionality): I have created the New Feature page in the project wiki explaining the functionality and how to use it. If relevant, I have committed sample data to the core seed to have usable examples in GardenWorld.
    • Breaking change (fix or feature that would cause existing functionality to not work as expected): I have documented the change in a clear way that everyone in the community can understand the impact of the change.
    • Improvement (improves and existing functionality): This documentation is needed if the improvement changes the way the user interacts with the system or the outcome of a process/task changes. If it is just, for instance, a performance improvement, documentation might not be needed.
  • The changed/added documentation is in the project wiki (not privately-hosted pdf files or links pointing to a company website) and is complete and self-explanatory.

@hengsin
Copy link
Collaborator Author

hengsin commented May 6, 2024

hi @norbertbede and @igorpojzl , please update the test result here, thanks.

@CarlosRuiz-globalqss
Copy link
Collaborator

Is there a way to test this in core?

@hengsin
Copy link
Collaborator Author

hengsin commented May 6, 2024

Is there a way to test this in core?

Create a custom model factory that is using the Query class.

Anyway, the core's unit test does ensure the change is unlikely to break anything in core. The new code is also much more safer than the current code in master.

@norbertbede
Copy link

hi. i can only say, based on igor test hengsin make the last patch which was taken and working well in production environment downgraded to v 10. I know that is no too much good answer,... norbert

@hengsin hengsin merged commit f442a61 into idempiere:master May 7, 2024
4 checks passed
@hengsin hengsin deleted the IDEMPIERE-6122 branch May 7, 2024 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants