New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IDEMPIERE-6129 Change column type #2338
IDEMPIERE-6129 Change column type #2338
Conversation
-- IDEMPIERE-6129 | ||
SELECT register_migration_script('202404261129_IDEMPIERE-6129.sql') FROM dual; | ||
|
||
ALTER TABLE t_selection_infowindow MODIFY value_string CLOB; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oracle threw this error:
ORA-22858: invalid alteration of datatype
Maybe better first to try to increase it to a 4000 char?
Otherwise, better to conduct full tests in oracle because the change could affect the way how the String is saved and retrieved.
-- IDEMPIERE-6129 | ||
SELECT register_migration_script('202404261129_IDEMPIERE-6129.sql') FROM dual; | ||
|
||
ALTER TABLE t_selection_infowindow ALTER COLUMN value_string TYPE TEXT; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not good to use different data type for PostgreSQL and Oracle.
-- IDEMPIERE-6129 | ||
SELECT register_migration_script('202404261129_IDEMPIERE-6129.sql') FROM dual; | ||
|
||
ALTER TABLE t_selection_infowindow MODIFY value_string VARCHAR2(4000); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for oracle we need to define explicitly CHAR on the size:
please apply the following patch:
pr2338PR1.patch.txt
https://idempiere.atlassian.net/browse/IDEMPIERE-6129
Pull Request Checklist
Tests
Documentation