Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDEMPIERE-6129 Change column type #2338

Merged
merged 4 commits into from May 14, 2024

Conversation

VitorVilla
Copy link
Contributor

@VitorVilla VitorVilla commented Apr 26, 2024

https://idempiere.atlassian.net/browse/IDEMPIERE-6129

Pull Request Checklist

  • My code follows the code guidelines of this project
  • My code follows the best practices of this project
  • I have performed a self-review of my own code
  • My code is easy to understand and review.
  • I have checked my code and corrected any misspellings
  • In hard-to-understand areas, I have commented my code.
  • My changes generate no new warnings

Tests

  • I have tested the direct scenario that my code is solving
  • I checked all collaterals that can be affected by my changes, and tested other potential affected scenarios
  • New and existing unit tests pass locally with my changes
  • I have added unit tests that prove my fix is effective or that my feature works

Documentation

  • I have made corresponding changes to the documentation as follows:
    • New feature (non-breaking change which adds functionality): I have created the New Feature page in the project wiki explaining the functionality and how to use it. If relevant, I have committed sample data to the core seed to have usable examples in GardenWorld.
    • Breaking change (fix or feature that would cause existing functionality to not work as expected): I have documented the change in a clear way that everyone in the community can understand the impact of the change.
    • Improvement (improves and existing functionality): This documentation is needed if the improvement changes the way the user interacts with the system or the outcome of a process/task changes. If it is just, for instance, a performance improvement, documentation might not be needed.
  • The changed/added documentation is in the project wiki (not privately-hosted pdf files or links pointing to a company website) and is complete and self-explanatory.

-- IDEMPIERE-6129
SELECT register_migration_script('202404261129_IDEMPIERE-6129.sql') FROM dual;

ALTER TABLE t_selection_infowindow MODIFY value_string CLOB;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oracle threw this error:
ORA-22858: invalid alteration of datatype

Maybe better first to try to increase it to a 4000 char?

Otherwise, better to conduct full tests in oracle because the change could affect the way how the String is saved and retrieved.

-- IDEMPIERE-6129
SELECT register_migration_script('202404261129_IDEMPIERE-6129.sql') FROM dual;

ALTER TABLE t_selection_infowindow ALTER COLUMN value_string TYPE TEXT;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not good to use different data type for PostgreSQL and Oracle.

@VitorVilla VitorVilla requested a review from hengsin May 9, 2024 12:29
-- IDEMPIERE-6129
SELECT register_migration_script('202404261129_IDEMPIERE-6129.sql') FROM dual;

ALTER TABLE t_selection_infowindow MODIFY value_string VARCHAR2(4000);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for oracle we need to define explicitly CHAR on the size:

please apply the following patch:
pr2338PR1.patch.txt

@CarlosRuiz-globalqss CarlosRuiz-globalqss merged commit 29661fb into idempiere:master May 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants