IDEMPIERE-5991:improve file download by append file list inside process result panel #2206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ss result panel (code resfactory)
…ss result panel (use new api)
…ss result panel (use new api) AbstractProcessDialog at line 1464 set file export to file download
CarlosRuiz-globalqss
requested changes
Jan 24, 2024
| processUI.download(outFile); | ||
| else if( getProcessInfo() != null ){ | ||
| ProcessInfo m_pi = getProcessInfo(); | ||
| ProcessInfo m_pi = getProcessInfo(); |
There was a problem hiding this comment.
Now this process is not showing the user the output file to download when in foreground
CarlosRuiz-globalqss
requested changes
Jan 24, 2024
There was a problem hiding this comment.
Hi @hieplq
I'm not sure if this is still work in progress - if it is - is better to open a draft pull request, so we can wait for review until finished
| @@ -192,9 +192,30 @@ public ProcessInfo (String Title, int AD_Process_ID) | |||
| private String showHelp = null; | |||
|
|
|||
| private int m_AD_Scheduler_ID = 0; | |||
| /** | |||
| * Files for download by user <br/> | |||
| * The file path for download is also stored in the {@link ProcessInfoLog#m_P_Msg} with the {@link ProcessInfoLog#getPInstanceLogType} set to {@link X_AD_PInstance_Log#PINSTANCELOGTYPE_FilePath} | |||
There was a problem hiding this comment.
This javadoc is referring to links that don't exist
| @@ -116,8 +116,11 @@ default public void askForInput(String message, MLookup lookup, int displayType, | |||
| } | |||
|
|
|||
| /** | |||
| * add to list of file available for download after process end | |||
| * Add to list of file available for download after process end<br/> | |||
| * While this API is limited to processes with user interfaces, consider using {@link SvrProcess#addDownloadFile(File)} for broader support, <br/> | |||
There was a problem hiding this comment.
this javadoc is referring to links that don't exist
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
Tests
Documentation