Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IDEMPIERE-4224 POC for decluttering concept #2051

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dpansheriya
Copy link
Contributor

@dpansheriya dpansheriya commented Oct 9, 2023

https://idempiere.atlassian.net/browse/IDEMPIERE-4224

Pull Request Checklist

  • My code follows the code guidelines of this project
  • My code follows the best practices of this project
  • I have performed a self-review of my own code
  • My code is easy to understand and review.
  • I have checked my code and corrected any misspellings
  • In hard-to-understand areas, I have commented my code.
  • My changes generate no new warnings

Tests

  • I have tested the direct scenario that my code is solving
  • I checked all collaterals that can be affected by my changes, and tested other potential affected scenarios
  • New and existing unit tests pass locally with my changes
  • I have added unit tests that prove my fix is effective or that my feature works

Documentation

  • I have made corresponding changes to the documentation as follows:
    • New feature (non-breaking change which adds functionality): I have created the New Feature page in the project wiki explaining the functionality and how to use it. If relevant, I have committed sample data to the core seed to have usable examples in GardenWorld.
    • Breaking change (fix or feature that would cause existing functionality to not work as expected): I have documented the change in a clear way that everyone in the community can understand the impact of the change.
    • Improvement (improves and existing functionality): This documentation is needed if the improvement changes the way the user interacts with the system or the outcome of a process/task changes. If it is just, for instance, a performance improvement, documentation might not be needed.
  • The changed/added documentation is in the project wiki (not privately-hosted pdf files or links pointing to a company website) and is complete and self-explanatory.

@dpansheriya
Copy link
Contributor Author

@CarlosRuiz-globalqss @hengsin please note that this is POC code, not final. So don't merge PR.
I am adding instruction and steps to be performed for testing this on ticket https://idempiere.atlassian.net/browse/IDEMPIERE-4224

@hengsin
Copy link
Collaborator

hengsin commented Oct 9, 2023

hi @dpansheriya , when a PR is not ready for merge, you should mark it as draft.

@dpansheriya
Copy link
Contributor Author

@hengsin I am not able to create label as Draft.

@hengsin
Copy link
Collaborator

hengsin commented Oct 10, 2023

hi @dpansheriya , there's the "convert to draft" link at top right corner (below Reviewers)

@dpansheriya dpansheriya marked this pull request as draft October 10, 2023 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants