Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Facebook Open Graph support #158

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Facebook Open Graph support #158

wants to merge 2 commits into from

Conversation

colinhumber
Copy link

Hi! I've updated the Facebook SDK to the new SDK with Open Graph support (https://github.com/facebook/facebook-ios-sdk). Includes Single Sign-on support. Tested all FB share types (URL, photo, and text) on devices that support and don't support multitasking. Also modified URL sharing to share as a link instead of straight text.

colinhumber and others added 2 commits January 27, 2011 15:30
Updated config file with new Facebook settings
Added additional dictionary elements to SHKItem dictionaryRepresentation
Updated example app to work with the new Facebook SDK
Updated config file with new Facebook settings
Added additional dictionary elements to SHKItem dictionaryRepresentation
Updated example app to work with the new Facebook SDK
@bobbypage
Copy link

Sweet, this looks awesome! I'll try try it out and get back to you.

@randytarampi
Copy link

It looks and works pretty awesome.

Also, this has made my week.

Nice job.

@randytarampi
Copy link

Hm. I think that Facebook should default to not auto share, that is:

  • (BOOL)shouldAutoShare {
     return NO; // FBConnect presented its own dialog, but since we're no longer using it anymore this might be useful
    }

Especially since FBConnect doesn't present it's dialog anymore.

@bobbypage
Copy link

Pretty cool stuff.

One thing though, I really hate Facebook's new single sign on system so I'm simply using the new sdk, but old dialog for entering username/password.

The system is just too complex and requires too much testing on different devices and OS versions...

If anyone's interested I do it like this:
Under facebook.m edit the method - (void)authorizeWithFBAppAuth:(BOOL)tryFBAppAuth safariAuth:(BOOL)trySafariAuth

And simply set both of the booleans to no at the the very beginning of the method:


- (void)authorizeWithFBAppAuth:(BOOL)tryFBAppAuth
                    safariAuth:(BOOL)trySafariAuth {
//To disable facebook single sign on:
    tryFBAppAuth = NO;
    trySafariAuth = NO;

@yosit
Copy link

yosit commented Feb 17, 2011

bobbypage, I disagree as it's easier for the user NOT to type a user and pass. it might be a testing hell but it's heaven for end users.

@bobbypage
Copy link

Hey,

I've added the option to enable or disable Facebook Single Sign-on directly from SHKConfig.h in my pull request: #138

-David

@@ -75,6 +90,12 @@
#define SHKTwitterUseXAuth 0 // To use xAuth, set to 1
#define SHKTwitterUsername @"" // Enter your app's twitter account if you'd like to ask the user to follow it when logging in. (Only for xAuth)

// Evernote - http://www.evernote.com/about/developer/api/
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This evernote config probably wasn't intended to be part of your pull request.

@scompt
Copy link

scompt commented Mar 5, 2011

Cool pull request. I'm looking forward to this ending up in the master.

@bchessin
Copy link

@colinhumber With this pull, all I see is my news feed. I am just trying to share the text but it doesn't seem to work at all. Any ideas?

@coryalder
Copy link

@Objective-Zero I was having the same issue, ShareKit kicks over to the Facebook app which checks that your app is authenticated, but if you don't have a URL handler set up correctly it won't go back to your app. The instructions in the facebook api docs are out of date. Add a URL type in Xcode under YourAppTarget->Info->URL Types.
Should be straightforward... all you need is an identifier (whatever you want) and a url scheme (something like fb1232914892189412 but with your facebook app id instead of 1232914892189412)

@holah-reiken
Copy link

I am doing some work on app code that was not originally mine. We are having the problem that users cannot login to Facebook through ShareKit, as it returns to the login screen with "To use Facebook, please select your Setting app - Safari - Accept Cookies - From visited". That setting is already set. From what I've read in this and related threads, it's a common problem that this pull might fix by using Facebook OpenGraph support, but I'm not clear on how I should be taking advantage of that. Unfortunately, it's not convenient to keep switching between versions, as there was some custom code added by prior developers of this app. I'm hoping someone can clarify what the issue is with Facebook, or point me to some other prior threads if they exist. Of course, I'm looking for the path of least resistance, and want to change as little as possible in the clients code to avoid regressions.

@colinhumber
Copy link
Author

I haven't had the time to work on the new Facebook support on this request due to work taking up pretty much all my time. There are a number of forks that have put in some great work on this, as well as the new Twitter support in iOS 5. Check out https://github.com/polydice/ShareKit, for example.

@colinhumber
Copy link
Author

I actually just saw that ShareKit was moved to another repo at https://github.com/ShareKit/ShareKit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants