Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sample Notebook for ATL08 #86

Open
wants to merge 8 commits into
base: development
Choose a base branch
from
Open

Sample Notebook for ATL08 #86

wants to merge 8 commits into from

Conversation

bidhya
Copy link

@bidhya bidhya commented Jun 18, 2020

Added a sample notebook for ATL08 inside the doc folder

@JessicaS11
Copy link
Member

Thanks @bidhya for this example (and apologies it's taken me so long to review your PR - I'm having trouble keeping up since the hackweek).

I'm hoping you'd be willing to make some revisions to more seamlessly integrate this example into icepyx. The notebook itself could use some more explanations to make it more beginner-friendly: what are you doing in each cell, and why? Overall, what makes your example unique or useful? I think that having quick data visualization examples is important, and this is a critical step towards that!

Another way that I think we could simplify this example would be to wrap some of the functions you have in the notebook into the icepyx code itself. Thinking about data reading/converting is already in the works and would ultimately provide a good home for that function. The gps2dyr conversion might be something we could use to expand the acceptable time inputs into an icepyx.query (formerly icepyx.icesat2data) object.

I'd be happy to work with you on making and integrating these changes!

@JessicaS11
Copy link
Member

@bidhya I'm making my way through some of these older PRs to either incorporate them or close them. I recently used some of the code from this example (with attribution, of course) in an intro tutorial notebook I put together using ATL08 (see #202). If you're interested, we could work together to re-introduce the capabilities you have within this PR for creating a shapefile or csv. Otherwise, I will close this PR and at some point remove the branch.

@bidhya
Copy link
Author

bidhya commented May 17, 2021

@bidhya I'm making my way through some of these older PRs to either incorporate them or close them. I recently used some of the code from this example (with attribution, of course) in an intro tutorial notebook I put together using ATL08 (see #202). If you're interested, we could work together to re-introduce the capabilities you have within this PR for creating a shapefile or csv. Otherwise, I will close this PR and at some point remove the branch.

Hi @JessicaS11 I am happy to follow your lead to incorporate some of the ALT08 goodies. I think it is best to move the codes to the new notebook you have created. After that I can supplement it with additional details as we both see fit

@JessicaS11
Copy link
Member

I think it is best to move the codes to the new notebook you have created. After that I can supplement it with additional details as we both see fit

Thanks, @bidhya! Would you mind checking out the new notebook in its current form and providing some feedback (probably best done within #202 itself). You could either add comments to the PR or the code itself (let me know if you're in need of some quick tips for navigating PRs to do so).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants