Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default encoding in TextOf to UTF8 #512

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

LeonardKrml
Copy link
Collaborator

@LeonardKrml LeonardKrml commented Mar 31, 2022

Please check if the PR fulfills these requirements

  • I made sure that my code builds
  • I merged the master into this branch before pushing
  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce?** (check one with "x")

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • CI related changes
  • Other... Please describe:

What is the current behavior? (You can also link to an open issue here)

#444

What is the new behavior?

TextOf default encoding is UTF8

Does this PR introduce a breaking change? (check one with "x")

  • Yes
  • No

If this PR contains a breaking change, please describe the impact and migration path for existing applications

Other information

@Meerownymous Meerownymous modified the milestone: 3.0.0 Apr 4, 2022
@Meerownymous Meerownymous changed the title I444 default encoding in text of CHange default encoding in TextOf to UTF8 Apr 7, 2022
@Meerownymous Meerownymous added the Breaking Change Existing signature is changed label Apr 7, 2022
@Meerownymous Meerownymous added this to the 3.0.0 milestone Apr 7, 2022
@HerickJ-22
Copy link
Contributor

HerickJ-22 commented May 16, 2022

Please also change the Encoding in LiveText.cs since there is also a possibly wrong encoding used like in TextOf

@koeeenig koeeenig changed the title CHange default encoding in TextOf to UTF8 Change default encoding in TextOf to UTF8 May 16, 2022
@koeeenig koeeenig removed this from the 3.0.0 milestone Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Breaking Change Existing signature is changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Default Encoding in TextOf and BytesOf is different [Breaking Change]
4 participants