Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default Encoding in TextOf and BytesOf is different [Breaking Change] #444

Open
HerickJ-22 opened this issue Oct 28, 2020 · 2 comments · May be fixed by #512
Open

Default Encoding in TextOf and BytesOf is different [Breaking Change] #444

HerickJ-22 opened this issue Oct 28, 2020 · 2 comments · May be fixed by #512
Assignees
@LeonardKrml
Labels
Bug
Milestone
4.0.0

Comments

@HerickJ-22
Copy link
Contributor

Expected Behavior

The default encoding in TextOf and BytesOf is the same

Actual Behavior

BytesOf uses Encoding.UTF8
TextOf uses Encoding.GetEncoding(0)
This can lead to errors if Bytes are encoded as text and then encoded back to bytes

Mention any other details that might be useful

Steps to reproduce the behavior

The log given by the failure.
@HerickJ-22 HerickJ-22 added the Bug label Oct 28, 2020
@aveXcaesar
Copy link
Contributor

We have several places where we use UTF8. I think we should adjust the default encoding for TextOf to Encoding.UTF8

@Meerownymous
Copy link
Collaborator

Yes, we already agreed on using UTF-8 for all our libraries.

@LeonardKrml LeonardKrml self-assigned this Mar 31, 2022
@LeonardKrml LeonardKrml linked a pull request Mar 31, 2022 that will close this issue
Change default encoding in TextOf to UTF8 #512
Open
14 tasks
@LeonardKrml LeonardKrml linked a pull request Mar 31, 2022 that will close this issue
Open
14 tasks
@koeeenig koeeenig added this to the next milestone Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LeonardKrml LeonardKrml

Labels
Bug
Projects
None yet
Milestone
4.0.0
Development

Successfully merging a pull request may close this issue.

Change default encoding in TextOf to UTF8 icarus-consulting/Yaapii.Atoms
5 participants
@Meerownymous @koeeenig @aveXcaesar @HerickJ-22 @LeonardKrml