fix: fix tests #112
Merged
fix: fix tests #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There were two issues preventing the tests from running: 1) The tests use the 'latest' image tag for MQ - and watch for a particular message code in the log to recognise when the queue manager is ready. Changes in a recent version of MQ meant that the log output has changed, so the tests were waiting forever for a log message that is no longer output. I've updated the message code to match the current MQ behaviour. 2) Fix for a regression that caused a NullPointerException when the MQSourceTaskIT test cleanup method ran - by renaming the locally-scoped SourceTask variable to use the class-scoped variable that the cleanup depends on. Signed-off-by: Dale Lane <dale.lane@uk.ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were two issues preventing the tests from running:
The tests use the 'latest' image tag for MQ - and watch for a particular message code in the log to recognise when the queue manager is ready. Changes in a recent version of MQ meant that the log output has changed, so the tests were waiting forever for a log message that is no longer output.
I've updated the message code to match the current MQ behaviour.
Fix for a regression that caused a NullPointerException when the MQSourceTaskIT test cleanup method ran - by renaming the locally-scoped SourceTask variable to use the class-scoped variable that the cleanup depends on.