feat: pom xml latest version update and xml format change #109
Conversation
pom.xml
Outdated
| <groupId>com.ibm.eventstreams.connect</groupId> | ||
| <artifactId>kafka-connect-mq-source</artifactId> | ||
| <packaging>jar</packaging> | ||
| <version>1.3.2</version> |
There was a problem hiding this comment.
because of the dependencies change, I think it warrants incrementing the version number to 1.3.3
(and making the equivalent changes to README and the version numbers baked in the Java)
| <dependency> | ||
| <groupId>org.apache.kafka</groupId> | ||
| <artifactId>connect-api</artifactId> | ||
| <version>3.4.0</version> |
There was a problem hiding this comment.
Would a jar built using a newer version of Kafka still work in a Connect runtime using an older version of Kafka?
(Apologies - I should know the answer to this!)
If yes - great.
If not - we should at least update the README (which currently says Kafka 2 here) to specify the minimum version of Connect required to use the connector if we make this change.
There was a problem hiding this comment.
Yes, it does work with older version of kafka connect runtime. I was able to test it with kafka-2.6.2 and higher also having mq 9 or higher. I have updated the readme with the same.
|
Just curious on the feature introduced in Apache Kafka version 3.3.1 for KIP-618: Exactly-Once support for source connectors. |
|
@david-VigneshN Exactly-once support is something that I've been looking at - as you point out, the newer versions of Kafka Connect do make this possible. This isn't completely "free" as some code changes will be needed in order to offer assurances for exactly-once support, but this is something I'm interested in. I'd be interested to know how important/useful that would be for your use case(s) if you'd be willing to share any details. |
|
@dalelane I was curious to know what changes it would take and good to have it added. It is not a mandatory for our current use cases. |
Joel-hanson
force-pushed
the
version-updates
branch
3 times, most recently
from
b4687d0
to
da07e8a
Compare
Joel-hanson
force-pushed
the
version-updates
branch
from
da07e8a
to
dad5d29
Compare
- updated pom.xml to latest version - updated xml format to be more consistent - updated Dockerfile to use latest version of kafka - New Dockerfile with updated versions of the base image and the packages installed in the image. - java distribution and pom package version updates - Update java distribution to semeru from temurin - Update com.ibm.mq.allclient to 9.3.2.1 to fix SNYK-JAVA-ORGJSON-5488379 - Update mockito-core to 4.11.0 to support java 8 - Update mq and kafka version support in README.md - Update version from 1.3.3 to 1.3.4 Signed-off-by: Joel Hanson <joelhanson025@gmail.com>
Joel-hanson
force-pushed
the
version-updates
branch
from
d57f081
to
3341ad9
Compare
and the packages installed in the image.
SNYK-JAVA-ORGJSON-5488379