[patch] Add mongodb_version to update pipelinerun #947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whitfiea
requested review from
durera,
andrercm,
terenceq and
alequint
as code owners
|
I found that 'mongodb_version' is also missing in the 'mas-update' pipeline definition. So, probably /tekton/src/pipelines/update.yml.js also needs to be updated? |
|
@andrercm can you review again please?. This is now verified to work. |
andrercm
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mongodb_version was missing from the pipelinerun for update, so when the cli sets it here
cli/image/cli/mascli/functions/update
Line 686 in c602b9d