[patch] handle return codes #928
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
racree
requested review from
durera,
andrercm,
sanjayprab,
terenceq,
whitfiea and
alequint
as code owners
|
@racree Can you add a description of this change into the PR text? |
tomklapiscak
reviewed
May 3, 2024
There was a problem hiding this comment.
I've taken a look through and I can't see any obvious problems. However, this is the sort of thing we really need to put through an end-to-end test before merging into the gitops branch (and risk breaking fvtsaas). Rick's going to raise a story for next sprint to make sure that gets done 👍
NOTE: please make sure this branch pulls in the latest from the gitops branch before doing any further testing.
|
Verified deployed VisualInspection to rick instance on noble3. 
|
whitfiea
approved these changes
May 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check return codes of commands executed in the Tekton tasks and supporting scripts/functions and exit on failure.