-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[major] Pick up ibm.mas_devops v19 #827
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 6f12580.
Co-authored-by: David Parker <parkerda@uk.ibm.com>
…ion (#954) Co-authored-by: Sanjay Prabhakar <sanjay.prabhakar@uk.ibm.com>
durera
requested review from
andrercm,
terenceq,
whitfiea and
alequint
as code owners
May 15, 2024 16:18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ansible Update
FVT Evolution
Evolution of the way MAS FVT is handled, turning it into a generic system that can be re-used by customers as a simple approval system supporting approval points for multiple stages of the install pipeline leveraging a series of configmaps:
This system allows users to prevent the pipeline proceeding until an update is made to a configmap in the pipelines namespace. How that configmap is updated is completely up to the customer, it could be a manual process (bad) which allows a manual review of the update as it progresses, or (good) it could be being updated by parallel automation running alongside the install pipeline.
MAS FVT is an excellent example of how to use this system:
First, we create empty configmaps for all of the approval points we want to enable
Then we start two pipelines' mas-install and mas-fvt. Where the two need to coordinate activities the configmaps are used: mas-install will initialise
FVT_STATUS=pending
in the configmap, this is the trigger for the mas-fvt pipeline to start the appropriate FVT tied to that approval, the mas-install pipeline will not progress further until the value is changed frompending
toapproved
, which the mas-fvt pipeline does once testing is complete.The existence of the configmap with the key
CONFIGMAP_KEY
is what enables this system. If the configmap does not exist, ofCONFIGMAP_KEY
is not set, then nothing additional happens compared to what a normal customer install is todayThe task in the install pipeline:
The task in the fvt pipeline:
Neither task in eithe pipleine knows about the other, they just know about the configmap, which acts as the bridge to synchronize the activities of the two pipelines; but it could just as easily synchronize any parallel activity that we want to sync up to certain stages in the install pipeline.
Breaking Changes