Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed hash equality from yy_modelIsEqual: #279

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

TarekkMA
Copy link

@TarekkMA TarekkMA commented Feb 9, 2018

This is a fix for #278 . hash equality won't work if the object doesn't ovrride the hash method.

@codecov-io
Copy link

Codecov Report

Merging #279 into master will decrease coverage by 5.32%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #279      +/-   ##
==========================================
- Coverage   99.28%   93.95%   -5.33%     
==========================================
  Files           2        2              
  Lines        1540     1539       -1     
  Branches        0      421     +421     
==========================================
- Hits         1529     1446      -83     
+ Misses         11        7       -4     
- Partials        0       86      +86
Impacted Files Coverage Δ
YYModel/NSObject+YYModel.m 93.35% <ø> (-5.87%) ⬇️
YYModel/YYClassInfo.m 96.92% <0%> (-2.7%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1230e60...778b6c3. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants