Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Go router implement #42

Closed
wants to merge 4 commits into from
Closed

Go router implement #42

wants to merge 4 commits into from

Conversation

DarshanAsalaliya
Copy link

implement go router

  • add go_router in pubspec.yaml -change navigator to gorouter in every page home_screen, login_sign_up_screen, splash_screen.

@DarshanAsalaliya
Go router implement
72dce96 
implement go router
- add go_router in pubspec.yaml
-change navigator to gorouter in every page home_screen, login_sign_up_screen, splash_screen,
@ibhavikmakwana ibhavikmakwana added the enhancement New feature or request label Feb 19, 2024
@ibhavikmakwana ibhavikmakwana linked an issue Feb 19, 2024 that may be closed by this pull request
Implement go_router #40
Open
ibhavikmakwana
ibhavikmakwana requested changes Feb 19, 2024
View reviewed changes
lib/screen/dashboard/home/home_screen.dart Outdated Show resolved Hide resolved
lib/screen/onboarding/login_sign_up_screen.dart Outdated Show resolved Hide resolved
lib/screen/onboarding/login_sign_up_screen.dart Outdated Show resolved Hide resolved
pubspec.yaml Outdated
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To avoid potential merge conflicts, let's focus on the core functionality changes in this file for now. We can address any unnecessary formatting adjustments in a separate pull request later.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what i understand is from this statement is i don't need to push pubspec.yaml in this pull request even it needs.
cause i add new dependensy in pubspec.yaml file.
so guide me if i got a wrong.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Push only the added dependency changes in pubspec.yaml (ignore formatting).

@ibhavikmakwana
Copy link
Owner

Hey @DarshanAsalaliya,
thanks for your contribution! I've decided to take the project in a different direction that requires it to be private. I won't be merging this PR, but your work is appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ibhavikmakwana ibhavikmakwana ibhavikmakwana requested changes

Assignees

@DarshanAsalaliya DarshanAsalaliya

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement go_router
2 participants
@DarshanAsalaliya @ibhavikmakwana