Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom STUN/TURN server configuration support #33

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

g0ne150
Copy link

@g0ne150 g0ne150 commented Apr 16, 2020

No description provided.

.gitignore Outdated Show resolved Hide resolved
.env.template Show resolved Hide resolved
@Chaphasilor
Copy link
Collaborator

Also, did you run npx prettier --write .?

@g0ne150
Copy link
Author

g0ne150 commented Apr 17, 2020

Also, did you run npx prettier --write .?

Yes, and nothing changed, Prettier is my default format tool.

Copy link
Collaborator

@Chaphasilor Chaphasilor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works as intended

@gfyre
Copy link

gfyre commented May 21, 2020

So does this still depend upon Twillio's STUN/TURN server or is this a custom, locally hosted server?

@Chaphasilor
Copy link
Collaborator

So does this still depend upon Twillio's STUN/TURN server or is this a custom, locally hosted server?

this will use twillio's TURN server if no custom one is specified, however you are now able to use a different server :)

@Chaphasilor
Copy link
Collaborator

@ianramzy I think we should merge this?

@Chaphasilor
Copy link
Collaborator

@g0ne150 we will merge this as soon as #49 is through. Sorry for the long wait :/

@realPy
Copy link

realPy commented Sep 12, 2020

Bad documentation
Will be
ICE_SERVER_URLS=stun:stun.l.google.com:19302,stun:stun1.l.google.com:19302,stun:stun2.l.google.com:19302,stun:stun3.l.google.com:19302,stun:stun4.l.google.com:19302

@Chaphasilor
Copy link
Collaborator

@realPy ?

@realPy
Copy link

realPy commented Sep 12, 2020

With ICE_SERVER_URLS=stun.l.google.com:19302 its not work .
ICE_SERVER_URLS=stun:stun.l.google.com:19302 is the right syntax :)

@Chaphasilor
Copy link
Collaborator

ICE_SERVER_URLS=stun:stun.l.google.com:19302 is the right syntax :)

Are you sure? Have you tested this?

@realPy
Copy link

realPy commented Sep 13, 2020

Yes,

I have try with my own stun server too with coturn and its work great. Without this not work for me.
And its on the JS documentation. (several example add the protocol )
Trickle-ice use also the scheme with stun.
https://webrtc.github.io/samples/src/content/peerconnection/trickle-ice/

@realPy
Copy link

realPy commented Sep 13, 2020

Documentation here:

https://developer.mozilla.org/en-US/docs/Web/API/RTCIceServer/urls

@realPy
Copy link

realPy commented Sep 14, 2020

Information for test:
stun work very well in network local and some other situation.
When 2 people is under nat, you MUST use a TURN server (https://github.com/coturn/coturn) ( the server act as relay )
There is NO free turn server you must start one. If you do this, you must use credentials (noauth not work for relay) and use the scheme "turn:"

@Chaphasilor
Copy link
Collaborator

@realPy thank you so much for the infos!

Also, if you have experience with setting up coturn to work with zipcall, a short guide would be awesome! :D

@realPy
Copy link

realPy commented Sep 14, 2020

Yes i will !
Because twilio can be expansive quickly when use turn : 0,4 dollars per giga.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants