Merge pull request #665 from iamvishnusankar/fix/exclude-favicon-route

[Feat] Exclude favicon from sitemaps
iamvishnusankar · Jul 1, 2023 · b951757 · b951757
2 parents dd3a619 + 46c5e3c
commit b951757
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 5 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -13,7 +13,7 @@ jobs:
   test:
     strategy:
       matrix:
-        platform: [ubuntu-latest, macos-latest, windows-latest]
+        platform: [ubuntu-latest, macos-latest] # windows-latest]
         node: ['16', '18']
     runs-on: ${{ matrix.platform }}
     steps:

diff --git a/.yarn/install-state.gz b/.yarn/install-state.gz
diff --git a/.yarnrc.yml b/.yarnrc.yml
@@ -27,4 +27,4 @@ supportedArchitectures:
     - current
     - darwin
     - linux
-    - win32
+    - windows
diff --git a/packages/next-sitemap/src/utils/__tests__/url.test.ts b/packages/next-sitemap/src/utils/__tests__/url.test.ts
@@ -47,6 +47,7 @@ describe('next-sitemap/url', () => {
     expect(isNextInternalUrl('/about/_middleware')).toBeTruthy()
     expect(isNextInternalUrl('/some_url/about/_middleware')).toBeTruthy()
     expect(isNextInternalUrl('/projects/[id]/_middleware')).toBeTruthy()
+    expect(isNextInternalUrl('/favicon.ico')).toBeTruthy()
   })
 
   test('isNextInternalUrl: url params', () => {

diff --git a/packages/next-sitemap/src/utils/url.ts b/packages/next-sitemap/src/utils/url.ts
@@ -16,9 +16,9 @@ export const generateUrl = (baseUrl: string, slug: string): string => {
  * @param path path check
  */
 export const isNextInternalUrl = (path: string): boolean => {
-  return new RegExp(/[^/]*^.[_]|^\/(404|500)$|\/_middleware$|(?:\[)/g).test(
-    path
-  )
+  return new RegExp(
+    /[^/]*^.[_]|^\/(404|500)$|\/_middleware$|favicon.ico|(?:\[)/g
+  ).test(path)
 }
 
 /**