Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Advanced format output with short offset name #2637

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

Fix: Advanced format output with short offset name #2637

wants to merge 1 commit into from
+40 −11

Conversation

klm-turing
Copy link
Contributor

@klm-turing klm-turing commented Apr 23, 2024 •
edited

  • Used of long timezone name by default in Intl.DateTimeFormat
  • Extract and cached short offset name from the long one in the offsetName function
  • Writing related unit test

This fix 1713 issue

@klm-lab
Fix advanced format output with short offset name
f413f25 
Used of long timezone name by default in Intl.DateTimeFormat
Extract and cached short offset name from the long one in the offsetName function
Writing related unit test
@klm-turing klm-turing mentioned this pull request Apr 23, 2024
Open
@et
Copy link

et commented May 20, 2024

Thanks for adding this! I definitely could use this in a moment migration.
@iamkun - curious if we can get this in?

Alternatively, have we considered replicating moment-timezone's zoneAbbr functionality?
https://momentjs.com/timezone/docs/#/using-timezones/formatting/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

advancedFormat's z outputs offset instead of abbreviated offset name for Central European Standard Time
3 participants
@klm-turing @et @klm-lab