feat(nonblocking) implement non blocking mode for connections #280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, and option to run all with any type
pankgeorg
force-pushed
the
pg/nonblock
branch
from
6c7f795
to
385b681
Compare
iamed2
requested changes
Sep 7, 2023
There was a problem hiding this comment.
I'm curious what the test results will reveal (mostly whether any other places need a call to PQflush).
I do know the copy functions also need a flush dance: https://www.postgresql.org/docs/current/libpq-copy.html#LIBPQ-COPY-SEND
pankgeorg
force-pushed
the
pg/nonblock
branch
from
cb28349
to
9e2c7f1
Compare
pankgeorg
commented
Sep 18, 2023
pankgeorg
commented
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards making this work https://github.com/TechEmpower/FrameworkBenchmarks/pull/8370/files (more context)
I'm trying to remove any blocking calls from anywhere in the Julia Web stack. Though this may be minor, I think it's not a bad idea to have it around!
I'll have numbers regarding whether this works soon™️ 😅
TODO (@iamed2 please add more as you please)