Add Documentation and Test-Case for DataFrame Upload using CSV.RowIterator #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iamed2
reviewed
Jul 2, 2020
Co-authored-by: Eric Davies <iamed2@gmail.com>
|
@iamed2 thanks for your feedback! |
|
bump, this looks good and could use this feature! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of
#172
A test case for uploading a DataFrame using the CSV.RowIterator and a corresponding example to the documentation has been added.
I had to update the version number of DataFrames so that it is compatible to the most recent version of CSV.jl, but this should not be an issue because it is only a test dependency and all tests are still working for me.