-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved PolyfaceQuery.ts #6725
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
saeeedtorabi
commented
May 13, 2024
- Improved formatting and documentations of PolyfaceQuery.ts.
- Improved behavior of dihedralAngleSummary and isConvexByDihedralAngleCount functions and fixed tests accordingly.
- Added md doc for polyface dihedral angles.
- Improved tests.
saeeedtorabi
commented
May 13, 2024
saeeedtorabi
commented
May 13, 2024
saeeedtorabi
commented
May 13, 2024
saeeedtorabi
commented
May 13, 2024
saeeedtorabi
commented
May 13, 2024
saeeedtorabi
commented
May 13, 2024
saeeedtorabi
commented
May 13, 2024
saeeedtorabi
commented
May 13, 2024
saeeedtorabi
commented
May 13, 2024
saeeedtorabi
commented
May 13, 2024
saeeedtorabi
commented
May 13, 2024
saeeedtorabi
commented
May 13, 2024
saeeedtorabi
commented
May 13, 2024
saeeedtorabi
commented
May 13, 2024
saeeedtorabi
commented
May 13, 2024
saeeedtorabi
commented
May 13, 2024
saeeedtorabi
commented
May 13, 2024
saeeedtorabi
force-pushed
the
saeed-torabi/polyface-query
branch
from
May 13, 2024 21:36
782b083
to
e39875e
Compare
dassaf4
requested changes
May 16, 2024
saeeedtorabi
force-pushed
the
saeed-torabi/polyface-query
branch
from
May 21, 2024 17:46
e39875e
to
a5059d3
Compare
- Improved formatting and documentations of PolyfaceQuery.ts. - Improved behavior of dihedralAngleSummary and isConvexByDihedralAngleCount functions and fixed tests accordingly. - Added md doc for polyface dihedral angles. - Improved tests.
saeeedtorabi
force-pushed
the
saeed-torabi/polyface-query
branch
from
May 21, 2024 18:20
0cd7135
to
9dafc7a
Compare
dassaf4
approved these changes
May 21, 2024
bbastings
approved these changes
May 21, 2024
hl662
pushed a commit
that referenced
this pull request
Jun 3, 2024
* Improved formatting and documentations of PolyfaceQuery.ts. * Improved behavior of dihedralAngleSummary and isConvexByDihedralAngleCount functions and fixed tests accordingly. * Added md doc for polyface dihedral angles. * Improved tests.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.