-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix inconsistent unit parsing #6599
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gnored, make sure we use the unit definition to come up with a conversion.
hl662
approved these changes
Apr 15, 2024
@ColinKerr @calebmshafer Any chance this could get reviewed at some point ? Thanks. |
aruniverse
approved these changes
May 29, 2024
hl662
added a commit
that referenced
this pull request
Jun 3, 2024
Co-authored-by: Arun George <11051042+aruniverse@users.noreply.github.com> Co-authored-by: Nam Le <50554904+hl662@users.noreply.github.com> Co-authored-by: Raphaël LEMIEUX <1904889+raplemie@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
The current Parser implementation is inconsistent when it comes to handling invalid tokens. When the parser spec contains a unit definition such as
units: [{ label: "ft", name: "Units.FT" }]
)`, we would expect that an invalid token would simply convert the value based off that unit as a fallback, but it doesn't.This is what parsing returns (output is always meters):
"4.0 ft" ==>
1.2192
"1.234 m" ==>
1.234
Even if we're in feet, there is a known unit that uses them
token (meters), so it interprets it correctly."4.0" == >
1.2192
Unitless will use the parser's spec unit definition which is Units.FT to convert the value."4.0 abcdef" ==>
4.0
This should have outputted1.2192
. Theabcdef
token does not relate to any known unit. This should be treated as unitless which would have applied the conversion factor properly.Fix:
Make sure we consider the unit definition when we fail to find any unit matching the token.
Parsing returns properly for all existing cases, including this one:
"4.0 abcdef" ==>
1.2192
Misc:
When we're parsing two tokens and the unit comes first (eg. currency conversion), just swap the entries in the 'token' array rather than duplicate the logic/code.