Surface a11y fix #1500
Merged
Surface a11y fix #1500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xman343
added
the
a11y
…winUI into xander/surface-a11y-fix
23 tasks
xman343
requested review from
gretanausedaite and
siddhantrawal
and removed request for
a team
mayank99
reviewed
Aug 17, 2023
mayank99
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
#1148 - Currently, two
Surfaceexamples are failing the automated a11y tests.button-namerulelabelSettingsgiven to the settings button inHeaderFooterExample.list(ul and ol must only directly contain li, script or template elements) andscrollable-region-focusable(Scrollable region must have keyboard access) rulesas='li'for each<Divider>in the<ul>. This helpsNoPaddingExamplefollow thelistrule.Anchorswithin the<ul>inNoPaddingExampleso that the region will be keyboard accessible; all interactive elements (including links) must be keyboard accessible.The examples and / or components will be modified to resolve these rule violations.
Testing
Testing will be conducted through the Cypress web a11y script. Any breaking changes will be evaluated through unit testing & visual tests.
I am also reading the examples with NVDA to assess their screen reader compatibility.
Docs
N/A