Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

button group a11y compliance #1404

Merged
merged 12 commits into from
Jul 17, 2023
Merged

button group a11y compliance #1404

merged 12 commits into from
Jul 17, 2023

Conversation

xman343
Copy link
Contributor

@xman343 xman343 commented Jul 11, 2023 •
edited

Changes

Bringing ButtonGroup examples to a11y compliance. ButtonGroup component brought to compliance by removing aria-orientation attribute .
Addresses #1148

Testing

Unit testing & visual testing will be conducted.

Docs

N/A

@xman343 xman343 self-assigned this Jul 11, 2023
@xman343 xman343 added the a11y Accessibility issues (keyboard navigation, color contrast, assistive technologies, semantics, etc) label Jul 11, 2023
@xman343 xman343 marked this pull request as ready for review July 17, 2023 15:28
@xman343 xman343 requested review from a team as code owners July 17, 2023 15:28
@xman343 xman343 requested review from mayank99 and adamhock and removed request for a team July 17, 2023 15:29
mayank99
mayank99 reviewed Jul 17, 2023
View reviewed changes
examples/ButtonGroup.main.tsx Outdated Show resolved Hide resolved
examples/ButtonGroup.input.tsx Outdated Show resolved Hide resolved
.changeset/ten-grapes-approve.md Outdated Show resolved Hide resolved
xman343 and others added 3 commits July 17, 2023 13:29
@xman343 @mayank99
Update .changeset/ten-grapes-approve.md
759b7de 
Co-authored-by: Mayank <9084735+mayank99@users.noreply.github.com>
@xman343
label fixes
af956f5
@xman343
overflow label fix
3a1c7e7
adamhock
adamhock approved these changes Jul 17, 2023
View reviewed changes
.changeset/ten-grapes-approve.md
'@itwin/itwinui-react': patch
---

`aria-orientation` attribute removed from ButtonGroup to meet accessibility requirements.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would mention this in the PR description

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@xman343 xman343 added this pull request to the merge queue Jul 17, 2023
Merged via the queue into dev with commit e83cac6 Jul 17, 2023
16 of 17 checks passed
@xman343 xman343 deleted the xander/button-group-a11y branch July 17, 2023 19:45
@imodeljs-admin imodeljs-admin mentioned this pull request Jul 17, 2023
Merged
@xman343 xman343 mentioned this pull request Aug 4, 2023
Open
23 tasks
@imodeljs-admin imodeljs-admin mentioned this pull request Oct 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mayank99 mayank99 mayank99 approved these changes

@adamhock adamhock adamhock approved these changes

Assignees

@xman343 xman343

Labels
a11y Accessibility issues (keyboard navigation, color contrast, assistive technologies, semantics, etc)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xman343 @mayank99 @adamhock