Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring failing Avatar examples to a11y compliance #1397

Merged
merged 12 commits into from
Jul 10, 2023

Conversation

xman343
Copy link
Contributor

@xman343 xman343 commented Jul 6, 2023

Changes

Editing the Avatar examples that are violating a11y rules to make them compliant. Component-level changes may be needed.

Addresses issue 1148.

Testing

Accessibility tested thru Cypress a11y tests. Unit and visual tests run as well.

Docs

N/A

@xman343 xman343 added the a11y Accessibility issues (keyboard navigation, color contrast, assistive technologies, semantics, etc) label Jul 6, 2023
@xman343 xman343 self-assigned this Jul 6, 2023
@xman343
Copy link
Contributor Author

xman343 commented Jul 7, 2023

All Avatar examples now pass a11y test.
image

@xman343 xman343 marked this pull request as ready for review July 7, 2023 15:40
@xman343 xman343 requested review from a team as code owners July 7, 2023 15:40
@xman343 xman343 requested review from gretanausedaite and LostABike and removed request for a team July 7, 2023 15:40
examples/Avatar.main.tsx Outdated Show resolved Hide resolved
packages/itwinui-react/src/core/Avatar/Avatar.tsx Outdated Show resolved Hide resolved
testing/a11y/cypress.config.js Outdated Show resolved Hide resolved
.changeset/stale-scissors-march.md Outdated Show resolved Hide resolved
.changeset/stale-scissors-march.md Outdated Show resolved Hide resolved
xman343 and others added 2 commits July 10, 2023 11:41
Co-authored-by: Mayank <9084735+mayank99@users.noreply.github.com>
Co-authored-by: Mayank <9084735+mayank99@users.noreply.github.com>
Copy link
Contributor

@LostABike LostABike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@xman343 xman343 added this pull request to the merge queue Jul 10, 2023
Merged via the queue into dev with commit a098cb7 Jul 10, 2023
15 of 17 checks passed
@xman343 xman343 deleted the xander/avatar-a11y-examples branch July 10, 2023 18:54
@imodeljs-admin imodeljs-admin mentioned this pull request Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Accessibility issues (keyboard navigation, color contrast, assistive technologies, semantics, etc)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants