Adding Sidebar Scroll Arrows for DJI 03 OSD and some other updates. #10031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzaro-dev
changed the title
|
It should actually be decoration. |
|
I see, OK, didn't know that. Should I open another PR to make the necessary change in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think that there is just a small mismatch between the configurator documentation and the fimware variables.
The configurator uses the term
DECORATIONwhile the firmware variabe usesDIRECTTIONfor the same pointers0x15and0x16.When uncommenting these lines in the
displayport_msp_bf_compat.cfile, there is a build error because theSYM_AH_DECORATION_UPandSYM_AH_DECORATION_DOWNdo not exist inosd_symbols.h.I suggest going with what is in the firmware and just updating the INAV Character Map.md (I'll open another PR for that one) and the file from this PR so that they all match up.
I hope this change can be accepted. :)