Bugfix posix signals #5960
Merged
Bugfix posix signals #5960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SIGUSR1 was registered twice. Signed-off-by: Andre Werner <andre.werner@systec-electronic.com>
As this variable is only written once it may benefit from constness during optimizations. As well, the size should not be accidentally changed since the array lays at the stack and has a fixed size. Signed-off-by: Andre Werner <andre.werner@systec-electronic.com>
desmana
pushed a commit
to desmana/i3
that referenced
this pull request
Apr 3, 2024
Since there is no separate error handling the `SIGUSR2` signal is registered to get the write return code after exiting the program. Fixes i3#5958 --------- Signed-off-by: Andre Werner <andre.werner@systec-electronic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since there is no separate error handling the
SIGUSR2signal is registered to get the write return code after exiting the program.Additionally, the
num_watchersvariable is made const since it depends on a fixed array size and should not be modifyable after creation. Optimization can also benefit from const value.Fixes #5958