feat(i3wm): rounded corners

[jbenden]

Revives patch set to implement rounded corners!

This should be the minimum needed; whereas, previous PRs included miscellaneous changes related to other repo/sites.

See: #5410
See: #5429

[orestisfl]

Test failures need to be investigated and we would preferably need new tests

[jbenden]

For some reason, I am completely unable to locally run the test-suite; so I must use CI to assist. I will solve as many test-case failures as I can.

[jbenden]

I got the tests all working locally, so hopefully all is well now.

I could use ideas on a test-case to write for this... I am not sure how to check for a graphical change, with the existing test-suite.w

[jbenden]

QA test fail; but when commenting out a region within src/con.c the environment again looks acceptable. Current patch includes the commented out region.

[orestisfl]

If we are already saving this in the container, I would add a corresponding command as well to change the radius, for consistency with the border directive/command

[orestisfl]

If we don't want a command, then I wouldn't save it in the Con level at all, since it means that the setting is not updated when changing and reloading configuration.

[jbenden]

@orestisfl I have pushed a new patchset that includes a command, exports into JSON tree, and has a small unit-test to ensure values did pass around correctly.

[orestisfl]

A 1-pixel rounder border corner is not very smooth in the corner, for example in this image you can see the background blending in the border.

border_radius 10
gaps inner 20
border pixel 1

[jbenden]

Hi @orestisfl !

With regards to the single pixel border: I think both items are handled completely different, and incompatibly so.

The corner radius modification is accomplished by means of a mask applied to the viewing window.

This means the code that draws this border would also need to drawing arcs on the corners of containers/windows...

Thoughts, comments, suggestions are welcomed!

[orestisfl]

Okay, so the option is practically incompatible with window borders? That seems like a serious limitation.

[georglauterbach]

I'm not familiar with i3wm code, but I'm good at C. If you need my assistance, please ping me and I will try to help 😌

[okraits]

Okay, so the option is practically incompatible with window borders? That seems like a serious limitation.

I already asked that some time ago and didn't get an answer: #5410 (comment)
This doesn't look good IMO.

[jbenden]

This is not possible using the API's available from X11. An OpenGL-style mask is simply applied to the viewable region.

But if a requirement, then all border graphics must be drawn in software.

[orestisfl]

I'll need to invest more time to understand the underlying issue but I'll say as a general statement that I will not merge something that is incompatible with a very basic feature of i3. We have made very explicit that we focus on bug-fixing instead of new features (#5410 (comment)) and commiting something that is already not working bug-free goes against that.

The corner radius modification is accomplished by means of a mask applied to the viewing window.

Do you mean that the mask cannot be applied to border + window at the same time?

But if a requirement, then all border graphics must be drawn in software.

What exactly do you mean here?

[jbenden]

Hi @orestisfl !

You might be right about not accepting new features!

The current implementation uses features of X11 to "cookie-cut" the windows rounded. It easy to do (with xcb) and hardware assisted. However; borders are NOT possible with it. It is VERY stable patch, though!!! I've used it for some time now, happily and w/o a border applied. :)

I wrote a quick new drawing code for rounded rectangle; but cannot figure out how to apply it above the incoming frames from the application drawing.

Thoughts, comments, suggestions are welcomed!

[georglauterbach]

@orestisfl what's the state of this now? will this be merged?

[orestisfl]

@orestisfl what's the state of this now? will this be merged?

I think this is currently blocked because of #5686 (review)

[georglauterbach]

Ah, I see, thanks for the update.

I wrote a quick new drawing code for rounded rectangle; but cannot figure out how to apply it above the incoming frames from the application drawing.

@jbenden do you need my help with that? I don't know the i3 code at all, but when 4 eyes are looking at the problem, we may figure something out.

[orestisfl]

This also seems to break border colors for me

before

after

if you can't reproduce I can provide an MRE. But in general it seems that this approach has a lot of conflicts with borders?