Ignore Motif hints on window when swallowed by placeholder #5663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually, considering this case:
wouldn't it be valid to maintain the style dictated by Motif hints? |
A layout placeholder's border style should be preserved when swallowing a matching window, regardless of any Motif hints.
njhanley
force-pushed
the
motif-hints-on-placeholders
branch
from
75b3eed
to
50e058e
Compare
|
Could you give an example use case? I can't imagine wanting to restore a layout and not caring about the style. There's currently no such thing as a placeholder with no border style; placeholders are containers and take the default style on creation. We could add the concept of implicit default style with a new |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A layout placeholder's border style should be preserved when swallowing a matching window, regardless of any Motif hints.
Closes #5438