-
Notifications
You must be signed in to change notification settings - Fork 770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dead link for Modern Perl book #5648
Conversation
7923998
to
82ebdb9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that this book is not available online and seems quite old, maybe it's better to just let test writers select their own Perl resources instead of directing them to potentially outdated info? WDYT @stapelberg
Hmm, not sure. I think the book is still valuable, though building it from source is not something that people will do, I think. Could we build it from source and distribute a static PDF version of it, or does the license not permit that? |
The book might be useful indeed but instructing contributors on how to learn a language is not really typical for an open source project. Besides, it might be discouraging people rather than helping them; it creates the impression that one has to read a full book before actually contributing to i3 ("Please read the following documents before working on tests"). I believe that for the scope of what we are doing, great knowledge of perl is not needed to contribute to i3. I've personally never read the book. |
You can, the works has a Creative Commons Attribution-Noncommercial-Share Although I agree with @orestisfl's statement: The book might be useful indeed but instructing contributors on how to learn a language is not really typical for an open source project. |
Okay. I have saved a copy of the PDF, you can refer to it as https://i3wm.org/downloads/modern_perl_a4.pdf
Yes, but Perl isn’t really a typical language for an open source project either (these days). I’m open to changing the wording to seem less daunting, but I do think it is good to provide a few pointers regarding known-good resources to get into Perl for people who prefer that approach. Of course, everyone is free to disregard the advice and just jump into the code :) |
82ebdb9
to
d79a917
Compare
I updated the link in the PR.
Perl is a great language :) |
d79a917
to
fa38b81
Compare
Closes: i3#5523 Signed-off-by: Wesley Schwengle <wesleys@opperschaap.net>
fa38b81
to
d3afeab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Closes: #5523