Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dead link for Modern Perl book #5648

Merged
merged 1 commit into from
Sep 4, 2023

Conversation

waterkip
Copy link
Contributor

@waterkip waterkip commented Aug 31, 2023

Closes: #5523

Copy link
Member

@orestisfl orestisfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that this book is not available online and seems quite old, maybe it's better to just let test writers select their own Perl resources instead of directing them to potentially outdated info? WDYT @stapelberg

@stapelberg
Copy link
Member

Given that this book is not available online and seems quite old, maybe it's better to just let test writers select their own Perl resources instead of directing them to potentially outdated info? WDYT @stapelberg

Hmm, not sure. I think the book is still valuable, though building it from source is not something that people will do, I think. Could we build it from source and distribute a static PDF version of it, or does the license not permit that?

@orestisfl
Copy link
Member

The book might be useful indeed but instructing contributors on how to learn a language is not really typical for an open source project. Besides, it might be discouraging people rather than helping them; it creates the impression that one has to read a full book before actually contributing to i3 ("Please read the following documents before working on tests"). I believe that for the scope of what we are doing, great knowledge of perl is not needed to contribute to i3. I've personally never read the book.

@waterkip
Copy link
Contributor Author

waterkip commented Sep 3, 2023

Could we build it from source and distribute a static PDF version of it, or does the license not permit that?

You can, the works has a Creative Commons Attribution-Noncommercial-Share
Alike 3.0 United States License.

Although I agree with @orestisfl's statement: The book might be useful indeed but instructing contributors on how to learn a language is not really typical for an open source project.

@stapelberg
Copy link
Member

You can, the works has a Creative Commons Attribution-Noncommercial-Share Alike 3.0 United States License.

Okay. I have saved a copy of the PDF, you can refer to it as https://i3wm.org/downloads/modern_perl_a4.pdf

Although I agree with @orestisfl's statement: The book might be useful indeed but instructing contributors on how to learn a language is not really typical for an open source project.

Yes, but Perl isn’t really a typical language for an open source project either (these days). I’m open to changing the wording to seem less daunting, but I do think it is good to provide a few pointers regarding known-good resources to get into Perl for people who prefer that approach. Of course, everyone is free to disregard the advice and just jump into the code :)

@waterkip
Copy link
Contributor Author

waterkip commented Sep 3, 2023

You can, the works has a Creative Commons Attribution-Noncommercial-Share Alike 3.0 United States License.

Okay. I have saved a copy of the PDF, you can refer to it as https://i3wm.org/downloads/modern_perl_a4.pdf

I updated the link in the PR.

Yes, but Perl isn’t really a typical language for an open source project either (these days). I’m open to changing the wording to seem less daunting, but I do think it is good to provide a few pointers regarding known-good resources to get into Perl for people who prefer that approach. Of course, everyone is free to disregard the advice and just jump into the code :)

Perl is a great language :)

Closes: i3#5523

Signed-off-by: Wesley Schwengle <wesleys@opperschaap.net>
Copy link
Member

@orestisfl orestisfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@orestisfl orestisfl merged commit c6befec into i3:next Sep 4, 2023
3 checks passed
@waterkip waterkip deleted the 5523-modern-perl_is_stale branch September 15, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

testsuite doc. stale perl book URL
3 participants