Strip modifier keys of modifiers. #5383
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slyshot
force-pushed
the
strip-modifiers
branch
from
a320367
to
88a62e5
Compare
For some reason modifiers are applied to modifier keys being held down when a mode is loaded. I suspect this is a problem with xcb, as that's where we get key state. This strips modifiers of modifier keys. I don't see this breaking anything since modifiers with modifier keys isn't normally applied and is nonesense from the beginning. This fixes i3#5288.
slyshot
force-pushed
the
strip-modifiers
branch
from
88a62e5
to
504dea0
Compare
|
@slyshot Thanks for taking the time to work on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some reason modifiers are applied to modifier keys if they're held down when a mode is loaded. I suspect this is a problem with xcb -- I haven't been able to find another culprit yet. This strips modifier keys of modifiers. I don't see this breaking anything since modifiers aren't normally applied to modifier keys(Super, Shift, etc) and is nonesense from the beginning.
This fixes #5288.