Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix top border resizing registered on tiled windows #5378

Merged
merged 1 commit into from
May 5, 2023
Merged

Conversation

slyshot
Copy link
Contributor

@slyshot slyshot commented Jan 16, 2023

I noticed click+drag resize wasn't working on the top border of my tiled windows.
Unlike the other checks for where the mouse is clicked, it reference decoration. This commit makes it reference the borders like the other ones.

Thanks.

@orestisfl
Copy link
Member

This will probably conflict with

tiling_drag titlebar

@slyshot
Copy link
Contributor Author

slyshot commented Jan 18, 2023

Ah, so does keeping the old code and putting the new code in an else (or else if (dest == CLICK_BORDER)) to deal with both cases make sense?

Copy link
Member

@orestisfl orestisfl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay. It seems your change is fine as it is.

Can you add some release notes for this change?

echo 'fix top border resizing on tiling windows' > release-notes/bugfixes/1-top-border-resize
git add release-notes/bugfixes/1-top-border-resize

@orestisfl orestisfl merged commit fde43a0 into i3:next May 5, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants