Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom suggestions component and custom id and name keys #117

Closed
tjphopkins opened this issue Feb 20, 2018 · 4 comments
Closed

Custom suggestions component and custom id and name keys #117

tjphopkins opened this issue Feb 20, 2018 · 4 comments
Labels
Milestone

Comments

@tjphopkins
Copy link
Contributor

tjphopkins commented Feb 20, 2018

I would like to add a few features to this library. Would you accept a PR with the following?:

Custom id and name keys:

e.g. to enable one to pass in a list of suggestions of the form:
{thisIdKey: , thisnameKey: } with customIdKey='thisIdKey' and customNameKey=thisNameKey.

Currently you have to process your suggestions before passing them in as a prop, which has unnecessary performance implications.

Custom suggestions component prop, in the same vein as the tagComponent prop

Many thanks

@i-like-robots i-like-robots mentioned this issue Mar 19, 2018
Closed
12 tasks
@i-like-robots
Copy link
Owner

Added in #124

@i-like-robots i-like-robots added this to the 6.0.0 milestone Jul 3, 2018
@designbyadrian
Copy link

Where did this go?

@i-like-robots
Copy link
Owner

@designbyadrian this feature was added to v6 which you can try out here: https://github.com/i-like-robots/react-tags/tree/6.0

@designbyadrian
Copy link

@i-like-robots Silly me! Being ignorant, I assumed the pull request for V6 in 2018 was the current version 😄 I shall try out the new version!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants