Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

picker: Allow dialog resizing #173

Merged
merged 3 commits into from Jan 28, 2024
Merged

picker: Allow dialog resizing #173

merged 3 commits into from Jan 28, 2024

Conversation

rurigk
Copy link
Contributor

@rurigk rurigk commented Jan 25, 2024

I just adjusted the picker to be resizable
And now buttons dont use absolute positions

I have limited c++ and qt knowledge but not able to resize that dialog was driving me crazy

Copy link
Member

@vaxerski vaxerski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rest lgtm, nice work :)

hyprland-share-picker/mainpicker.ui Outdated Show resolved Hide resolved
@rurigk
Copy link
Contributor Author

rurigk commented Jan 26, 2024

I set the window size directly with setGeometry because restoreGeometry just didnt work

A comment about the size remembering of the dialog I used the QSettings to save the data but right now is being saved in the hypr directory as hyprland-share-picker.conf

I didnt want to create more config files but what was my option?
Save in a different dir and have more files spread in my system?
Use the xdph.conf? i dont know how it works and if its possible

@vaxerski
Copy link
Member

how about not remember the size?

@rurigk
Copy link
Contributor Author

rurigk commented Jan 26, 2024

Yeah you are right fuck the user

@rurigk rurigk reopened this Jan 27, 2024
@vaxerski vaxerski merged commit f29e046 into hyprwm:master Jan 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants