Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch package management from npm to yarn #359

Merged
merged 5 commits into from
May 16, 2017
Merged

Switch package management from npm to yarn #359

merged 5 commits into from
May 16, 2017

Commits on May 16, 2017

  1. Switch from npm to yarn for package management 

    Yarn provides much faster package installation, better resilience to npm
registry connection issues and most importantly for us, a much better
lockfile format.

This commit:

1. Replaces the npm shrinkwrap with the yarn lockfile using the
   following steps:

   1. Checkout latest version of master

   2. Remove node_modules folder and re-run `npm install`

   3. Run `yarn import` to generate a lockfile

2. Modifies the Makefile, Jenkinsfile, package.json and .travis.yml
   scripts to run `yarn` instead of `npm`.
    @robertknight
    robertknight committed May 16, 2017
    Configuration menu
    Copy the full SHA
    e8f08d4 View commit details
    Browse the repository at this point in the history

  2. Re-create Yarn lockfile from scratch 

    There were a couple of issues with the initial Yarn lockfile created via
`yarn import`:

1. `yarn check` reported several inconsistencies.

2. `phantomjs-prebuilt` needed to be upgraded to resolve a compatibility
   issue with Yarn.

This commit resolves these issues by just removing and recreating the
Yarn lockfile. In the process all dependencies have been upgraded to the
latest versions compatible with the constraints in package.json.
    @robertknight
    robertknight committed May 16, 2017
    Configuration menu
    Copy the full SHA
    ea4c57e View commit details
    Browse the repository at this point in the history

  3. Update to latest Node v6.x release 

    Package installation fails with Node v6.2 due to an incompatible
"check-dependencies" package. See
https://travis-ci.org/hypothesis/client/jobs/228937886
    @robertknight
    robertknight committed May 16, 2017
    Configuration menu
    Copy the full SHA
    ea3cf49 View commit details
    Browse the repository at this point in the history

  4. Add Yarn to list of development prerequisites

    @robertknight
    robertknight committed May 16, 2017
    Configuration menu
    Copy the full SHA
    e3e7760 View commit details
    Browse the repository at this point in the history

  5. Update yarn lockfile 

    Update lockfile with result of running `yarn install` with yarn v0.23.2.
    @robertknight
    robertknight committed May 16, 2017
    Configuration menu
    Copy the full SHA
    d8f60dc View commit details
    Browse the repository at this point in the history