-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update grpc dep to 1.43.2 #134
base: main
Are you sure you want to change the base?
Conversation
Codecov Report
@@ Coverage Diff @@
## main #134 +/- ##
=========================================
Coverage 81.66% 81.66%
Complexity 591 591
=========================================
Files 58 58
Lines 2269 2269
Branches 234 234
=========================================
Hits 1853 1853
Misses 321 321
Partials 95 95
Flags with carried forward coverage won't be shown. Click here to find out more. Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you fix the snyk issues?
So i have fixed the protobuf ones but it still shows older version. Others are due to pinot-client which i don't want to upgrade right now as it needs more testing |
I believe all of the ones being flagged right now are just expired suppressions, can just update the expiration dates: Lines 4 to 25 in d5b0829
|
Description
Please include a summary of the change, motivation and context.
Testing
Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.
Checklist:
Documentation
Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.