Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update grpc dep to 1.43.2 #134

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

update grpc dep to 1.43.2 #134

wants to merge 1 commit into from

Conversation

surajpuvvada
Copy link
Contributor

Description

Please include a summary of the change, motivation and context.

Testing

Please describe the tests that you ran to verify your changes. Please summarize what did you test and what needs to be tested e.g. deployed and tested helm chart locally.

Checklist:

  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • Any dependent changes have been merged and published in downstream modules

Documentation

Make sure that you have documented corresponding changes in this repository or hypertrace docs repo if required.

@surajpuvvada surajpuvvada requested a review from a team January 25, 2022 01:03
@codecov
Copy link

codecov bot commented Jan 25, 2022

Codecov Report

Merging #134 (3f377e1) into main (d5b0829) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##               main     #134   +/-   ##
=========================================
  Coverage     81.66%   81.66%           
  Complexity      591      591           
=========================================
  Files            58       58           
  Lines          2269     2269           
  Branches        234      234           
=========================================
  Hits           1853     1853           
  Misses          321      321           
  Partials         95       95           
Flag Coverage Δ
integration 81.66% <ø> (ø)
unit 79.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d5b0829...3f377e1. Read the comment docs.

@github-actions
Copy link

Unit Test Results

  32 files  ±0    32 suites  ±0   9s ⏱️ -3s
188 tests ±0  188 ✔️ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 3f377e1. ± Comparison against base commit d5b0829.

Copy link
Contributor

@aaron-steinfeld aaron-steinfeld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix the snyk issues?

@surajpuvvada
Copy link
Contributor Author

Can you fix the snyk issues?

So i have fixed the protobuf ones but it still shows older version. Others are due to pinot-client which i don't want to upgrade right now as it needs more testing

@aaron-steinfeld
Copy link
Contributor

I believe all of the ones being flagged right now are just expired suppressions, can just update the expiration dates:

query-service/.snyk

Lines 4 to 25 in d5b0829

ignore:
SNYK-JAVA-LOG4J-572732:
- '*':
reason: no available replacement
expires: 2021-12-31T00:00:00.000Z
SNYK-JAVA-IONETTY-473694:
- '*':
reason: no available replacement
expires: 2021-12-31T00:00:00.000Z
SNYK-JAVA-IONETTY-1042268:
- '*':
reason: No replacement available
expires: 2021-12-31T00:00:00.000Z
SNYK-JAVA-LOG4J-1300176:
- '*':
reason: None Given
expires: 2021-12-31T00:00:00.000Z
SNYK-JAVA-LOG4J-2316893:
- '*':
reason: None Given
expires: 2021-12-31T00:00:00.000Z
created: 2021-12-14T18:05:26.628Z

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants